Move the fingerprint_style special case into DepKindVTable creation
#151936
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-query-system
Collaborator
Zalathar
force-pushed
the
fingerprint-style
branch
from
21e502a to
b4bf57b
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
petrochenkov
approved these changes
Feb 2, 2026
Member
Author
|
Assuming that approval means r+. r? petrochenkov |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
Rollup of 11 pull requests Successful merges: - #151378 (Codegen tests for Arm Cortex-R82) - #151936 (Move the `fingerprint_style` special case into `DepKindVTable` creation) - #152018 (Move bigint helper tracking issues) - #151958 (Add codegen test for SLP vectorization) - #151974 (Update documentation for `Result::ok()`) - #151975 (Work around rustfmt giving up on a large expression) - #151990 (Fix missing unused_variables lint when using a match guard) - #151995 (stabilize ptr_as_ref_unchecked) - #151999 (attribute parsing: pass recovery mode to Parser.) - #152009 (Port rustc_preserve_ub_checks to attr parser) - #152022 (rustc-dev-guide subtree update) Failed merges: - #151968 (Remove `HasDepContext` by merging it into `QueryContext`)
Contributor
It usually does not, but in this case r=me indeed. |
rust-timer
added a commit
that referenced
this pull request
Feb 3, 2026
Rollup merge of #151936 - Zalathar:fingerprint-style, r=petrochenkov Move the `fingerprint_style` special case into `DepKindVTable` creation I'm a little bit fuzzy on *precisely* why anonymous queries are treated as having `FingerprintStyle::Opaque`, but I'm pretty confident that baking this special case into the query vtable is equivalent to the current behaviour, while being marginally more efficient. (I believe this special case comes from anonymous queries not having a fingerprint in the first place, so “opaque” is just there to signal that reconstructing a key is impossible.)
Zoxc
reviewed
Feb 3, 2026
| /// Query key was `()` or equivalent, so fingerprint is just zero. | ||
| Unit, | ||
| /// Some opaque hash. | ||
| /// The fingerprint is an opaque hash, and a key cannot be reconstructed from it. |
Contributor
There was a problem hiding this comment.
Note that in the anon case the fingerprint isn't even a hash of the key.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Feb 4, 2026
Rollup of 11 pull requests Successful merges: - rust-lang/rust#151378 (Codegen tests for Arm Cortex-R82) - rust-lang/rust#151936 (Move the `fingerprint_style` special case into `DepKindVTable` creation) - rust-lang/rust#152018 (Move bigint helper tracking issues) - rust-lang/rust#151958 (Add codegen test for SLP vectorization) - rust-lang/rust#151974 (Update documentation for `Result::ok()`) - rust-lang/rust#151975 (Work around rustfmt giving up on a large expression) - rust-lang/rust#151990 (Fix missing unused_variables lint when using a match guard) - rust-lang/rust#151995 (stabilize ptr_as_ref_unchecked) - rust-lang/rust#151999 (attribute parsing: pass recovery mode to Parser.) - rust-lang/rust#152009 (Port rustc_preserve_ub_checks to attr parser) - rust-lang/rust#152022 (rustc-dev-guide subtree update) Failed merges: - rust-lang/rust#151968 (Remove `HasDepContext` by merging it into `QueryContext`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a little bit fuzzy on precisely why anonymous queries are treated as having
FingerprintStyle::Opaque, but I'm pretty confident that baking this special case into the query vtable is equivalent to the current behaviour, while being marginally more efficient.(I believe this special case comes from anonymous queries not having a fingerprint in the first place, so “opaque” is just there to signal that reconstructing a key is impossible.)