Fix missing unused_variables lint when using a match guard #151990
Merged
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Within a binding pattern match guard, only real reads of a bound local impact its liveness analysis - not the fake read that is injected.
eggyal
force-pushed
the
unused-in-match-with-guard
branch
from
ebaae22 to
5aba6b1
Compare
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
nnethercote
approved these changes
Feb 3, 2026
| let (lhs, rhs) = match expr.kind { | ||
| ExprKind::Binary(op, lhs, rhs) if matches!(op.node, BinOpKind::Sub,) => (lhs, rhs), | ||
| ExprKind::MethodCall(fn_name, lhs, [rhs], _) if cx.ty_based_def(expr).is_diag_item(cx, sym::sub) => { | ||
| ExprKind::MethodCall(_, lhs, [rhs], _) if cx.ty_based_def(expr).is_diag_item(cx, sym::sub) => { |
Contributor
There was a problem hiding this comment.
Ha, nice that this finds a real case in clippy.
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
Rollup of 11 pull requests Successful merges: - #151378 (Codegen tests for Arm Cortex-R82) - #151936 (Move the `fingerprint_style` special case into `DepKindVTable` creation) - #152018 (Move bigint helper tracking issues) - #151958 (Add codegen test for SLP vectorization) - #151974 (Update documentation for `Result::ok()`) - #151975 (Work around rustfmt giving up on a large expression) - #151990 (Fix missing unused_variables lint when using a match guard) - #151995 (stabilize ptr_as_ref_unchecked) - #151999 (attribute parsing: pass recovery mode to Parser.) - #152009 (Port rustc_preserve_ub_checks to attr parser) - #152022 (rustc-dev-guide subtree update) Failed merges: - #151968 (Remove `HasDepContext` by merging it into `QueryContext`)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Feb 4, 2026
Rollup of 11 pull requests Successful merges: - rust-lang/rust#151378 (Codegen tests for Arm Cortex-R82) - rust-lang/rust#151936 (Move the `fingerprint_style` special case into `DepKindVTable` creation) - rust-lang/rust#152018 (Move bigint helper tracking issues) - rust-lang/rust#151958 (Add codegen test for SLP vectorization) - rust-lang/rust#151974 (Update documentation for `Result::ok()`) - rust-lang/rust#151975 (Work around rustfmt giving up on a large expression) - rust-lang/rust#151990 (Fix missing unused_variables lint when using a match guard) - rust-lang/rust#151995 (stabilize ptr_as_ref_unchecked) - rust-lang/rust#151999 (attribute parsing: pass recovery mode to Parser.) - rust-lang/rust#152009 (Port rustc_preserve_ub_checks to attr parser) - rust-lang/rust#152022 (rustc-dev-guide subtree update) Failed merges: - rust-lang/rust#151968 (Remove `HasDepContext` by merging it into `QueryContext`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within a binding pattern match guard, only real reads of a bound local impact its liveness analysis - not the fake read that is injected.
Fixes #151983
r? compiler