Move bigint helper tracking issues #152018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
clarfonthey
force-pushed
the
bigint-tracking-issues
branch
from
f9a1cf6 to
42463b3
Compare
Collaborator
|
cc @Amanieu, @folkertdev, @sayantn |
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
clarfonthey
force-pushed
the
bigint-tracking-issues
branch
from
42463b3 to
28feae0
Compare
clarfonthey
commented
Feb 2, 2026
| //@ compile-flags: -C llvm-args=-x86-asm-syntax=intel | ||
|
|
||
| #![no_std] | ||
| #![feature(bigint_helper_methods)] |
Contributor
Author
There was a problem hiding this comment.
From what I understand, this and the codegen-llvm test both could have removed the feature during the initial stabilisation, but for some reason, this wasn't noticed by our existing lints?
Member
There was a problem hiding this comment.
Assembly and codegen tests don't deny warnings, IIRC, and don't show the compilation output from rustc, so it makes sense that they're not noticed.
Member
There was a problem hiding this comment.
Oh, and so long as the feature exists I think it's normal that it doesn't lint that you didn't need the feature? At least for language features I don't think there's enough tracking to even tell, though I suppose for library features maybe there could be...
Member
|
Looks good! Thanks for doing the split. r? scottmcm |
Contributor
rust-bors
bot
added
the
S-waiting-on-bors
rust-bors
bot
removed
the
S-waiting-on-review
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
Rollup of 11 pull requests Successful merges: - #151378 (Codegen tests for Arm Cortex-R82) - #151936 (Move the `fingerprint_style` special case into `DepKindVTable` creation) - #152018 (Move bigint helper tracking issues) - #151958 (Add codegen test for SLP vectorization) - #151974 (Update documentation for `Result::ok()`) - #151975 (Work around rustfmt giving up on a large expression) - #151990 (Fix missing unused_variables lint when using a match guard) - #151995 (stabilize ptr_as_ref_unchecked) - #151999 (attribute parsing: pass recovery mode to Parser.) - #152009 (Port rustc_preserve_ub_checks to attr parser) - #152022 (rustc-dev-guide subtree update) Failed merges: - #151968 (Remove `HasDepContext` by merging it into `QueryContext`)
rust-timer
added a commit
that referenced
this pull request
Feb 3, 2026
Rollup merge of #152018 - clarfonthey:bigint-tracking-issues, r=scottmcm Move bigint helper tracking issues Closes #85532. This splits the remainder of the `bigint_helper_methods` tracking issue into three issues: * `signed_bigint_helpers`: #151989 * `widening_mul`: #152016 * `const_unsigned_bigint_helpers`: #152015 Note that the existing stable methods were merged under the `unsigned_bigint_helpers` feature as part of #144494.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Feb 4, 2026
Rollup of 11 pull requests Successful merges: - rust-lang/rust#151378 (Codegen tests for Arm Cortex-R82) - rust-lang/rust#151936 (Move the `fingerprint_style` special case into `DepKindVTable` creation) - rust-lang/rust#152018 (Move bigint helper tracking issues) - rust-lang/rust#151958 (Add codegen test for SLP vectorization) - rust-lang/rust#151974 (Update documentation for `Result::ok()`) - rust-lang/rust#151975 (Work around rustfmt giving up on a large expression) - rust-lang/rust#151990 (Fix missing unused_variables lint when using a match guard) - rust-lang/rust#151995 (stabilize ptr_as_ref_unchecked) - rust-lang/rust#151999 (attribute parsing: pass recovery mode to Parser.) - rust-lang/rust#152009 (Port rustc_preserve_ub_checks to attr parser) - rust-lang/rust#152022 (rustc-dev-guide subtree update) Failed merges: - rust-lang/rust#151968 (Remove `HasDepContext` by merging it into `QueryContext`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85532.
This splits the remainder of the
bigint_helper_methodstracking issue into three issues:signed_bigint_helpers: Tracking Issue for signed bigint helper methods #151989widening_mul: Tracking Issue for "widening" multiplication methods #152016const_unsigned_bigint_helpers: Tracking Issue for const stability of unsigned bigint helpers #152015Note that the existing stable methods were merged under the
unsigned_bigint_helpersfeature as part of #144494.