rust-analyzer subtree update#156437
Merged
Merged
Conversation
…s back to source code I'm not sure about the mapping the other way back, though - should we override them for the existing pattern?
Not sure why they regress, but the inserting of variables for parameters isn't that used anyway.
…iscompare fix: use Pattern_White_Space for whitespace handling
Example
---
```rust
mod foo {
pub struct OtherThing;
pub struct RefCell<T>(T);
impl<T> RefCell<T> {
pub fn new(t: T) -> Self { RefCell(t) }
}
}
fn main() {
let thing: foo::RefCell<foo::OtherThing> = foo::OtherThing.$0;
}
```
**Before this PR**
```rust
fn main() {
let thing: foo::RefCell<foo::OtherThing> = RefCell<OtherThing>::new(foo::OtherThing$0);
}
```
**After this PR**
```rust
fn main() {
let thing: foo::RefCell<foo::OtherThing> = foo::RefCell::new(foo::OtherThing$0);
}
```
rustc uses this struct to store all information about an ADT, but we have other types and are mainly using it for the solver. So store only the information we need.
perf: Do not intern `AdtDef`
…-generate-function Migrate generate function to SyntaxEditor
fix: qualify .new path and no complete generic params
There was a note in the docs that const blocks aren't visited, but most people don't read the docs and expect them to be visited. If you don't want them to, you can handle them specially.
So we can debug the test we have that gets stuck.
minor: Show running tests on CI
fix: Improve prettify_macro_expansion()
Example
---
```rust
fn main() {
$0{
92
}
()
}
```
**Before this PR**
```rust
fn main() {
92
()
}
```
**After this PR**
```rust
fn main() {
92;
()
}
```
Decide not to resolve a FIXME
fix: add semicolon after expr in stmt for unwrap_branch
Example
---
```rust
fn main() {
let s = cond.is_some().if$0;
}
```
**Before this PR**
```rust
fn main() {
let s = if cond.is_some() {
$0
};
}
```
**After this PR**
```rust
fn main() {
let s = if cond.is_some() {
$1
} else {
$0
};
}
```
…ine-call internal: migrate `inline_call` assist to `SyntaxEditor`
…alue feat: support if-else in value on postfix completions
internal: fix incorrect offset on multiple indel
Resolves a FIXME at hir-ty/src/infer/pat.rs that allowed
record patterns like `let S { foo, foo } = ...;` to type-check
with no error. Pushes the InferenceDiagnostic::DuplicateField
variant (added in rust-lang/rust-analyzer#22235) at the pattern
site; the cooked diagnostic already supports ExprOrPatId, so no
plumbing changes are needed.
Tests: struct pattern positive, enum variant pattern positive.
Part of rust-lang/rust-analyzer#22140.
Signed-off-by: Onyeka Obi <softwareengineerasaservant@isurvivable.cv>
…ld-pat ide-diagnostics: emit error for duplicate field in record pattern
…-derive-macro Migrate derive macro to syntax editor
…-convert-closure-to-fn migrate convert closure to fn to SyntaxEditor
Update generated lints
…ce-pat feat: add diagnostic for E0529
…acro fix: add whitespaces on postfix completion in macro
internal: Remove interning from query_group
internal: Refactor visiting and tracking of placeholder types
This updates the rust-version file to 8afb6a8.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@8afb6a8 Filtered ref: rust-lang/rust-analyzer@82d0ddb Upstream diff: rust-lang/rust@1d72d7e...8afb6a8 This merge was created using https://github.com/rust-lang/josh-sync.
rustbot
added
the
S-waiting-on-review
Member
Author
|
@bors r+ p=1 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
May 11, 2026
…uwer Rollup of 13 pull requests Successful merges: - #156437 (`rust-analyzer` subtree update) - #156357 (tests: ip*_properties: avoid parsing the IP over and over again) - #156389 (prepare fs tests for miri) - #156147 (Update ICU4X to 2.2) - #156375 (kernel_copy tests: properly join background threads) - #156406 (resolve: Module-related refactorings) - #155946 (Refuse to push changes with a dirty git client) - #156282 (Update `sysinfo` version to `0.39.0`) - #156372 (remove allows_weak_linkage target spec flag) - #156384 (Remove some dead code for dumping MIR for a single DefId) - #156392 (Improve doc comments for f32::ceil() and f32::floor()) - #156411 (bootstrap: Don't panic on `x install --set build.extended=true`) - #156426 (Fix unwanted "Available on XX-bit only" in libcore integers)
rust-timer
added a commit
that referenced
this pull request
May 11, 2026
Rollup merge of #156437 - lnicola:sync-from-ra, r=lnicola `rust-analyzer` subtree update Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@e2a5867. Created using https://github.com/rust-lang/josh-sync. r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtree update of
rust-analyzerto rust-lang/rust-analyzer@e2a5867.Created using https://github.com/rust-lang/josh-sync.
r? @ghost