Skip to content

rustfmt: format const trait impls to const impl for syntax transition#156815

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
fee1-dead-contrib:rustfmt-const-traits
May 22, 2026
Merged

rustfmt: format const trait impls to const impl for syntax transition#156815
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
fee1-dead-contrib:rustfmt-const-traits

Conversation

@fee1-dead
Copy link
Copy Markdown
Member

Because this concerns rustc development (we want this in next beta) so that we can ensure by the next beta rustc can remove the parser support for impl const Trait, this PR is made against the r-l/r repo :)

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 22, 2026

The Rustfmt subtree was changed

cc @rust-lang/rustfmt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. labels May 22, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 22, 2026

r? @ytmimi

rustbot has assigned @ytmimi.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: rustfmt, rustfmt-contributors
  • rustfmt, rustfmt-contributors expanded to 6 candidates

@fee1-dead fee1-dead changed the title Rustfmt: format everything to const impl for syntax transition rustfmt: format const trait impls to const impl for syntax transition May 22, 2026
@fee1-dead fee1-dead force-pushed the rustfmt-const-traits branch from 8d00e3b to a29df2a Compare May 22, 2026 08:04
@ytmimi
Copy link
Copy Markdown
Contributor

ytmimi commented May 22, 2026

Changes look good to me, and seems reasonable for why we opened this up here in r-l/r.

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 22, 2026

📌 Commit a29df2a has been approved by ytmimi

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2026
rust-bors Bot pushed a commit that referenced this pull request May 22, 2026
…uwer

Rollup of 10 pull requests

Successful merges:

 - #155509 ([Debug Info] Gracefully handle invalid `String`/`Vec`)
 - #156229 (Install additional LLVM DLL on Windows)
 - #152821 (Allow forbidden target features to be hard errors)
 - #156560 (compiler: fix duplicated "the" in two doc-comments)
 - #156725 (Remove stale RTN FIXME for assoc item constraint fallback)
 - #156803 (Fix reborrow ICE in MIR place lowering)
 - #156815 (rustfmt: format const trait impls to `const impl` for syntax transition)
 - #156818 (Privacy: enqueue type alias)
 - #156820 (delegation: visit body under elided-infer lifetime rib)
 - #156829 (Turn `lint_index` from `Option<u16>` to `u16` for LintExpectationId)
rust-bors Bot pushed a commit that referenced this pull request May 22, 2026
…uwer

Rollup of 10 pull requests

Successful merges:

 - #155509 ([Debug Info] Gracefully handle invalid `String`/`Vec`)
 - #156229 (Install additional LLVM DLL on Windows)
 - #152821 (Allow forbidden target features to be hard errors)
 - #156560 (compiler: fix duplicated "the" in two doc-comments)
 - #156725 (Remove stale RTN FIXME for assoc item constraint fallback)
 - #156803 (Fix reborrow ICE in MIR place lowering)
 - #156815 (rustfmt: format const trait impls to `const impl` for syntax transition)
 - #156818 (Privacy: enqueue type alias)
 - #156820 (delegation: visit body under elided-infer lifetime rib)
 - #156829 (Turn `lint_index` from `Option<u16>` to `u16` for LintExpectationId)
@rust-bors rust-bors Bot merged commit 1dcd2ae into rust-lang:main May 22, 2026
11 checks passed
@rustbot rustbot added this to the 1.98.0 milestone May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants