Turn lint_index from Option<u16> to u16 for LintExpectationId#156829
Merged
Conversation
rustbot
added
S-waiting-on-review
Bryntet
force-pushed
the
levels_options_removal
branch
from
5db6b28 to
4f12864
Compare
nnethercote
approved these changes
May 22, 2026
Contributor
|
nice @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
May 22, 2026
…uwer Rollup of 10 pull requests Successful merges: - #155509 ([Debug Info] Gracefully handle invalid `String`/`Vec`) - #156229 (Install additional LLVM DLL on Windows) - #152821 (Allow forbidden target features to be hard errors) - #156560 (compiler: fix duplicated "the" in two doc-comments) - #156725 (Remove stale RTN FIXME for assoc item constraint fallback) - #156803 (Fix reborrow ICE in MIR place lowering) - #156815 (rustfmt: format const trait impls to `const impl` for syntax transition) - #156818 (Privacy: enqueue type alias) - #156820 (delegation: visit body under elided-infer lifetime rib) - #156829 (Turn `lint_index` from `Option<u16>` to `u16` for LintExpectationId)
rust-bors Bot
pushed a commit
that referenced
this pull request
May 22, 2026
…uwer Rollup of 10 pull requests Successful merges: - #155509 ([Debug Info] Gracefully handle invalid `String`/`Vec`) - #156229 (Install additional LLVM DLL on Windows) - #152821 (Allow forbidden target features to be hard errors) - #156560 (compiler: fix duplicated "the" in two doc-comments) - #156725 (Remove stale RTN FIXME for assoc item constraint fallback) - #156803 (Fix reborrow ICE in MIR place lowering) - #156815 (rustfmt: format const trait impls to `const impl` for syntax transition) - #156818 (Privacy: enqueue type alias) - #156820 (delegation: visit body under elided-infer lifetime rib) - #156829 (Turn `lint_index` from `Option<u16>` to `u16` for LintExpectationId)
rust-timer
added a commit
that referenced
this pull request
May 22, 2026
Rollup merge of #156829 - Bryntet:levels_options_removal, r=nnethercote Turn `lint_index` from `Option<u16>` to `u16` for LintExpectationId While doing lint attributes PR, I realised that the field `lint_index` didn't need to be Optional (this PR is part of a series of PRs that will make the lint attrs PR more easily reviewable) r? @nnethercote because you did #156596 recently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While doing lint attributes PR, I realised that the field
lint_indexdidn't need to be Optional(this PR is part of a series of PRs that will make the lint attrs PR more easily reviewable)
r? @nnethercote because you did #156596 recently