Revert "drop derive helpers during ast lowering" #157150
Open
JonathanBrouwer wants to merge 2 commits into
Open
Revert "drop derive helpers during ast lowering" #157150JonathanBrouwer wants to merge 2 commits into
JonathanBrouwer wants to merge 2 commits into
Conversation
Collaborator
|
These commits modify Please ensure that if you've changed the output:
cc @aDotInTheVoid, @obi1kenobi Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Collaborator
|
r? @oli-obk rustbot has assigned @oli-obk. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This reverts commit 29e9273
JonathanBrouwer
force-pushed
the
fix-attrs
branch
from
05a903e to
5be8451
Compare
rustbot
added
S-waiting-on-author
Contributor
|
I hate this but it's the right thing to do for now. We can fix it later once we work out how @bors r+ rollup |
Contributor
|
📋 Only open, non-draft PRs can be approved. |
Contributor
|
Oh, r=me in that case |
rustbot
added
S-waiting-on-review
Contributor
Author
|
Let's revert first and then see if there's a better solution later |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 30, 2026
…zelmann Revert "drop derive helpers during ast lowering" Fixes rust-lang#157107 By undoing commit rust-lang@29e9273 from rust-lang#153540 cc @scrabsha @jdonszelmann
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 30, 2026
…zelmann Revert "drop derive helpers during ast lowering" Fixes rust-lang#157107 By undoing commit rust-lang@29e9273 from rust-lang#153540 cc @scrabsha @jdonszelmann
rust-bors Bot
pushed a commit
that referenced
this pull request
May 30, 2026
…uwer Rollup of 8 pull requests Successful merges: - #156863 (Make hint::cold_path #[cold] so that it works even if the MIR inliner can't inline it) - #156875 (Correct and document semantics of `yield` terminator) - #157115 ([rustdoc] Fix foreign items macro expansion) - #157150 (Revert "drop derive helpers during ast lowering" ) - #156887 (Rename `-Zdebuginfo-for-profiling` switch) - #157039 (rustdoc: correctly propagate cfgs for glob reexports) - #157125 (Rewrite the `#[repr]` attribute parser) - #157154 (Revert workaround used to select the gcc codegen in the coretests CI)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157107
By undoing commit 29e9273 from #153540
cc @scrabsha @jdonszelmann