Rollup of 13 pull requests by JonathanBrouwer · Pull Request #157266 · rust-lang/rust

JonathanBrouwer · 2026-06-01T17:35:55Z

Successful merges:

miri: require (almost) all 1-ZST arguments to be actually passed #156085 (miri: require (almost) all 1-ZST arguments to be actually passed)
Check arguments of attributes where no arguments are expected #155193 (Check arguments of attributes where no arguments are expected)
nix: remove some unneeded variables #156516 (nix: remove some unneeded variables)
Resolving Windows environment test failures #156562 (Resolving Windows environment test failures)
Don't drop uninit memory when MapWindows::clone panics #156588 (Don't drop uninit memory when MapWindows::clone panics)
Privacy: small cleanups #156673 (Privacy: small cleanups)
Add #[unsafe_eii] to unsafe EII UI tests #156817 (Add #[unsafe_eii] to unsafe EII UI tests)
Use #[panic_handler] rather than #[lang = "panic_impl"] #156924 (Use #[panic_handler] rather than #[lang = "panic_impl"])
LLVM 23: Run AssignGUIDPass in some places #157055 (LLVM 23: Run AssignGUIDPass in some places)
Add Xtensa va_arg assembly coverage #157108 (Add Xtensa va_arg assembly coverage)
cg_ssa: a bit less immediate_or_packed_pair #157220 (cg_ssa: a bit less immediate_or_packed_pair)
Trace ?id.local_def_index instead of id in def_path_hash #157241 (Trace ?id.local_def_index instead of id in def_path_hash)
Tune backport Zulip messages #157242 (Tune backport Zulip messages)

As preparation for turning #[panic_handler] from a weak lang item into an EII.

This is one of the things that made cg_clif not use cg_ssa, IIRC, so let's take the opportunities to avoid it where we can.

@folkertdev

…hlin miri: require (almost) all 1-ZST arguments to be actually passed We can't ignore *all* of them since the compiler itself relies on non-capturing closure arguments being ignored. Fixes rust-lang/miri#4993 Cc @folkertdev since it also changes the checks for variadics.

@jdonszelmann

…=jdonszelmann Check arguments of attributes where no arguments are expected This PR does the following: - Add a debug assertion to `rustc_attr_parsing`, to ensure we never forget to check the arguments of a meta item again - Removes the unused `#[derive(Clone)]` from `ArgParser` as that would break this debug assertion - **[BREAKING]** Properly check that `#[inline(always(...))]` gets no arguments - **[BREAKING]** Properly check that `#[instruction_set(arm::a32(...))]` gets no arguments - **[BREAKING]** Properly check that `#[macro_export(local_inner_macros(...))]` gets no arguments. Fixes rust-lang#154977 - **[BREAKING]** Properly check that `#[used(compiler(...))]` gets no arguments. - Properly check that `#[optimize(size(...))]` gets no arguments. - Properly check that `#[coverage(on(...))]` gets no arguments. - Properly check that `#[rustc_dump_layout(debug(...))]` gets no arguments. - Properly check that `#[rustc_abi(debug(...))]` gets no arguments. - Properly check that `#![test_runner(arg(...))]` gets no arguments. - Properly check that `#[rustc_must_implement_one_of(arg(...))]` gets no arguments. - Properly check that `#[allow_internal_unstable(arg(...))]` gets no arguments. - Properly check that `#[unstable_feature_bound(arg(...))]` gets no arguments. - Properly check that `#[rustc_allow_const_fn_unstable(arg(...))]` gets no arguments. - Properly check that `#[rustc_if_this_changed(arg(...))]` gets no arguments. - Properly check that `#[rustc_then_this_would_need(arg(...))]` gets no arguments. r? @jdonszelmann

nix: remove some unneeded variables Does not alter the semantics

rust-bors · 2026-06-01T18:53:44Z

💔 Test for 6b84e61 failed: CI. Failed job:

auto - x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-06-01T18:59:54Z

@bors retry

…uwer Rollup of 13 pull requests Successful merges: - #156085 (miri: require (almost) all 1-ZST arguments to be actually passed) - #155193 (Check arguments of attributes where no arguments are expected) - #156516 (nix: remove some unneeded variables) - #156562 (Resolving Windows environment test failures) - #156588 (Don't drop uninit memory when `MapWindows::clone` panics) - #156673 (Privacy: small cleanups) - #156817 (Add `#[unsafe_eii]` to unsafe EII UI tests) - #156924 (Use #[panic_handler] rather than #[lang = "panic_impl"]) - #157055 (LLVM 23: Run AssignGUIDPass in some places) - #157108 (Add Xtensa va_arg assembly coverage) - #157220 (cg_ssa: a bit less `immediate_or_packed_pair`) - #157241 (Trace `?id.local_def_index` instead of `id` in `def_path_hash`) - #157242 (Tune backport Zulip messages)

rust-bors · 2026-06-01T19:27:53Z

💔 Test for ef18367 failed: CI. Failed job:

auto - x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-06-01T19:37:34Z

@bors retry

JonathanBrouwer · 2026-06-01T19:37:50Z

@bors try jobs=x86_64-gnu-distcheck

Rollup of 13 pull requests try-job: x86_64-gnu-distcheck

rust-bors · 2026-06-01T22:07:39Z

☀️ Try build successful (CI)
Build commit: e31cdb2 (e31cdb2cf1f40747541f4ce7588be2f5f732c481, parent: c0bb140a37c81cf59a0b40c21c9413059644e294)

rust-bors · 2026-06-02T02:00:13Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 19m 59s
Pushing 4a31759 to main...

github-actions · 2026-06-02T02:03:17Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6bdf430 (parent) -> 4a31759 (this PR)

Test differences

Show 13 test diffs

Stage 1

[ui] tests/ui/attributes/args-checked.rs: [missing] -> pass (J0)
[ui] tests/ui/rustc-env/def-path-hash-ice-157238.rs: [missing] -> pass (J0)
[assembly] tests/assembly-llvm/c-variadic/xtensa.rs#XTENSA: [missing] -> pass (J4)
[assembly] tests/assembly-llvm/c-variadic/xtensa.rs#XTENSA: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J5)
iter::adapters::map_windows::drop_checks::panicking_clone: [missing] -> pass (J7)

Stage 2

[assembly] tests/assembly-llvm/c-variadic/xtensa.rs#XTENSA: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J1)
[ui] tests/ui/attributes/args-checked.rs: [missing] -> pass (J2)
[ui] tests/ui/rustc-env/def-path-hash-ice-157238.rs: [missing] -> pass (J2)
iter::adapters::map_windows::drop_checks::panicking_clone: [missing] -> pass (J3)
[assembly] tests/assembly-llvm/c-variadic/xtensa.rs#XTENSA: [missing] -> pass (J6)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4a31759ad18b3c29c5ec99ca23c4764a8bedcf52 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-arm-linux-musl: 1h 4m -> 1h 38m (+52.2%)
aarch64-apple: 2h 21m -> 3h 13m (+36.4%)
pr-check-2: 34m 12s -> 45m 28s (+32.9%)
dist-apple-various: 1h 58m -> 1h 25m (-27.8%)
x86_64-msvc-ext3: 1h 57m -> 1h 25m (-27.5%)
x86_64-gnu-llvm-22-1: 58m 46s -> 1h 12m (+23.3%)
x86_64-gnu-llvm-21-3: 1h 59m -> 1h 32m (-22.9%)
dist-aarch64-apple: 1h 29m -> 1h 47m (+20.5%)
dist-powerpc64le-linux-gnu: 1h 37m -> 1h 18m (-19.4%)
dist-x86_64-apple: 2h 27m -> 2h 6m (-14.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-06-02T02:04:10Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#155193	Check arguments of attributes where no arguments are expect…	`2013467fa8d0ee6c737352174719465f138ba25f` (link)
#156085	miri: require (almost) all 1-ZST arguments to be actually p…	`f3e57429005101d93bd93da03bcb6d744dc6557f` (link)
#156516	nix: remove some unneeded variables	`585986b73a671e36ff9168da5cdb774410943162` (link)
#156562	Resolving Windows environment test failures	`f9f0ce0cb0937a950dbdc7b2c763444524512d5b` (link)
#156588	Don't drop uninit memory when `MapWindows::clone` panics	`6a93f431aab6a2cbf5b334b8970f377adc2065d8` (link)
#156673	Privacy: small cleanups	`12e7119812a47a08491bc8d870c8906b126f536b` (link)
#156817	Add `#[unsafe_eii]` to unsafe EII UI tests	`81de2cc44e2a366902a3f39aafb87a377de4fa03` (link)
#156924	Use #[panic_handler] rather than #[lang = "panic_impl"]	`a79deacc062009649bb520f783d0a799f43e167b` (link)
#157055	LLVM 23: Run AssignGUIDPass in some places	`100b2c812cd75044a790ce83352ed117abe6bc5c` (link)
#157108	Add Xtensa va_arg assembly coverage	`8b96b0876723d30772dc0f1306956a5721b27f0a` (link)
#157220	cg_ssa: a bit less `immediate_or_packed_pair`	`d4daf1853e18433d34e4991a420bc7aed866d5d3` (link)
#157241	Trace `?id.local_def_index` instead of `id` in `def_path_ha…	`23dc0df4c505a3e4812ed00ac1085f538a65b9b4` (link)
#157242	Tune backport Zulip messages	`3349158cac139ce3ad3e2af338a7c43dff5b1b3f` (link)

previous master: 6bdf43094f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-06-02T03:05:07Z

Finished benchmarking commit (4a31759): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.2%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.2%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.9%	[3.9%, 3.9%]	1
Regressions ❌ (secondary)	1.2%	[1.0%, 1.6%]	5
Improvements ✅ (primary)	-1.6%	[-2.2%, -1.0%]	2
Improvements ✅ (secondary)	-3.3%	[-5.6%, -1.0%]	2
All ❌✅ (primary)	0.2%	[-2.2%, 3.9%]	3

Cycles

Results (primary -2.7%, secondary -3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.4%	[2.2%, 8.7%]	3
Improvements ✅ (primary)	-2.7%	[-2.7%, -2.7%]	1
Improvements ✅ (secondary)	-7.3%	[-17.8%, -2.1%]	8
All ❌✅ (primary)	-2.7%	[-2.7%, -2.7%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 512.33s -> 511.17s (-0.23%)
Artifact size: 400.60 MiB -> 400.72 MiB (0.03%)

GrigorenkoPV and others added 30 commits May 13, 2026 01:28

nix: remove some unneeded variables

f74c4fe

chore : Resolving Windows environment test failures

586d87a

Use #[panic_handler] rather than #[lang = "panic_impl"]

b8813df

As preparation for turning #[panic_handler] from a weak lang item into an EII.

LLVM 23: Run AssignGUIDPass in some places

cdb73bb

test: add xtensa va_arg assembly coverage

78eb52b

Add #[unsafe_eii] to unsafe EII UI tests

fba2ec9

Remove Clone from parser types

d2abca4

Add debug assertion to check usage of arguments of MetaItemParser

79e85e6

Properly check arguments of #[inline]

b3d4af3

Properly check arguments of #[instruction_set]

bf2db50

Properly check arguments of #[macro_export]

f3983c7

Properly check arguments of #[rustc_allow_const_fn_unstable]

f35ea0e

Properly check arguments of #[optimize]

5c90b79

Properly check arguments of #[coverage]

10c6c99

Properly check arguments of #[used]

4081ff4

Properly check arguments of #[rustc_must_implement_one_of]

6c7f601

Properly check arguments of #[rustc_dump_layout]

2b72962

Properly check arguments of query dep graph attrs

29b5a16

Properly check arguments of #[rustc_abi]

5bee968

Properly check arguments of #[test_runner]

3fcbca4

cg_ssa: a bit less immediate_or_packed_pair

dfc475d

This is one of the things that made cg_clif not use cg_ssa, IIRC, so let's take the opportunities to avoid it where we can.

miri: require (almost) all 1-ZST arguments to be actually passed

a96cc82

feat: Address review comments

bd30139

Tune backport Zulip messages

b592dd8

Trace ?id.local_def_index instead of id in def_path_hash

6fac60d

Don't drop uninit memory when panics

4a647a5

Privacy: small cleanups

2744044

Rollup merge of rust-lang#156516 - GrigorenkoPV:nix, r=WaffleLapkin

2bef860

nix: remove some unneeded variables Does not alter the semantics

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 1, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2026

rust-bors Bot mentioned this pull request Jun 1, 2026

introduce UnevaluatedConstKind #157094

Merged

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 1, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jun 1, 2026

Auto merge of #157266 - JonathanBrouwer:rollup-EIe7NPQ, r=<try>

e31cdb2

Rollup of 13 pull requests try-job: x86_64-gnu-distcheck

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 2, 2026

rust-bors Bot merged commit 4a31759 into rust-lang:main Jun 2, 2026
14 checks passed

rustbot added this to the 1.98.0 milestone Jun 2, 2026

This was referenced Jun 2, 2026

Implement argument-dependent target checking for the #[repr] parser #157215

Open

tests: codegen-llvm: Update bpf-alu32 with the new LLVM attributes #157249

Open

Uh oh!

Conversation

JonathanBrouwer commented Jun 1, 2026

Uh oh!

rust-bors Bot commented Jun 1, 2026

Uh oh!

JonathanBrouwer commented Jun 1, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 1, 2026

Uh oh!

JonathanBrouwer commented Jun 1, 2026

Uh oh!

JonathanBrouwer commented Jun 1, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 1, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 2, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 2, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 2, 2026

Uh oh!

rust-timer commented Jun 2, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants