Rollup of 25 pull requests by jhpratt · Pull Request #159942 · rust-lang/rust

jhpratt · 2026-07-26T04:21:57Z

Successful merges:

Support using const pointers in asm const operand #138618 (Support using const pointers in asm const operand)
Lower paths to functions in const args as ConstKind::Error #157962 (Lower paths to functions in const args as ConstKind::Error)
rustdoc: warn on improperly interleaved HTML/MD #158709 (rustdoc: warn on improperly interleaved HTML/MD)
Fix implicit_provenance_casts warnings on Xous #159174 (Fix implicit_provenance_casts warnings on Xous)
enable unreachable_cfg_select_predicates lint as part of unused lint group #159179 (enable unreachable_cfg_select_predicates lint as part of unused lint group)
iter: extend step_by specialization to cover StepBy<RangeIter<{integer}>> #159518 (iter: extend step_by specialization to cover StepBy<RangeIter<{integer}>>)
bootstrap: forward -fdebug-prefix-map when using cc #159673 (bootstrap: forward -fdebug-prefix-map when using cc)
Split non-local semicolon_in_expressions_from_macros into a separate lint #159700 (Split non-local semicolon_in_expressions_from_macros into a separate lint)
document #[global_allocator] constraints #159720 (document #[global_allocator] constraints)
optimization: don't look for diagnostic/canonical items without rustc_attrs enabled #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled)
implement CovariantUnsafeCell #159738 (implement CovariantUnsafeCell)
reuse regular exported_non_generic_symbols logic in Miri #159740 (reuse regular exported_non_generic_symbols logic in Miri)
check extern "custom" function pointers #159780 (check extern "custom" function pointers)
rustdoc-js: ignore editor temp files in test folder discovery #159786 (rustdoc-js: ignore editor temp files in test folder discovery)
std::sync::poison: disable auto_cfg on PoisonError::new #159819 (std::sync::poison: disable auto_cfg on PoisonError::new)
Fix typos and grammar in library documentation #152439 (Fix typos and grammar in library documentation)
stepping into where-clauses during normalization may be productive #155388 (stepping into where-clauses during normalization may be productive)
when bailing on ambiguity, don't force other results to ambig #155914 (when bailing on ambiguity, don't force other results to ambig)
Add support to caller_location to rustc_public #159204 (Add support to caller_location to rustc_public)
Fix(lib/fs/win): Fall back on Win32 delete for Dir::remove_file #159439 (Fix(lib/fs/win): Fall back on Win32 delete for Dir::remove_file)
Update wasm-component-ld to 0.5.27 #159676 (Update wasm-component-ld to 0.5.27)
proc_macro: Fix cfg_attr inner attrs in file modules #159695 (proc_macro: Fix cfg_attr inner attrs in file modules)
allow accessing the contents of UnsafeCell without going through get #159730 (allow accessing the contents of UnsafeCell without going through get)
Avoid #[target_features] #159809 (Avoid #[target_features])
bootstrap: Remove obsolete option build.compiletest-use-stage0-libtest #159878 (bootstrap: Remove obsolete option build.compiletest-use-stage0-libtest)

- library/core/src/macros/panic.md: remove duplicate word ("another other" → "another") - library/core/src/error.md: fix spacing ("Often times" → "Oftentimes") - library/core/src/ptr/docs/as_ref.md: fix wrong types in Null-unchecked section (&mut T → &T) - library/core/src/ffi/c_ulong.md: fix article ("an u64" → "a u64") - library/core/src/ffi/c_void.md: fix plural ("old Rust compiler" → "old Rust compilers") - library/core/src/ptr/docs/as_uninit_slice.md: fix subject-verb agreement ("is true" → "are true") - library/std_detect/README.md: fix article ("an user-space" → "a user-space")

Expose the internal `requires_caller_location` query through rustc_public so tools can detect when an instance has an implicit extra `&'static Location<'static>` argument in its ABI that is not present in the MIR body signature. Fixes rust-lang/rustc_public#123

Add an API to construct the `&'static Location<'static>` constant that must be passed as the implicit extra argument when calling a `#[track_caller]` function. Users provide the span of the call site (or the callee's definition span for reify shim fallback). Fixes rust-lang/rustc_public#62

Since cfg_select is stable since 1.95, this can be enabled.

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

This is probably not what the user wants: error: nested Markdown emphasis in HTML `style` tag --> $DIR/invalid-html-tags-correct-script-style.rs:11:16 | LL | /// One <style>*emph*</style> | ^^^^^^ Markdown translates this into HTML, but the browser parses it as CSS | help: to turn off Markdown parsing, put the tag at the start of the line | LL ~ /// One LL ~ /// <style>*emph*</style> |

The `test_dir_remove_file` test currently fails under Windows 7 on: ``` thread 'fs::tests::test_dir_remove_file' (2028) panicked at library/std/src/fs/tests.rs:2590:5: dir.remove_file("foo.txt") failed with: The parameter is incorrect. (os error 87) ``` Looking into it, this is because the `FILE_DISPOSITION_INFO_EX` variant of the `SetFileInformationByHandle` API is used while it is only available starting from Windows 10 1607. However, `FILE_DISPOSITION_INFO` is still available since Vista. This is therefore fixed by introducing a fallback to the latter API if the former fails. This is achieved by re-using some logic that is already available through `File::delete` and that does exactly this. Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>

Add a method Body::caller_location that resolves the correct caller location constant for a call to a #[track_caller] function, walking inlined source scopes to handle MIR inlining correctly. Body now stores source scope data as a public field. Body::new populates it with empty entries (no inlining info); bodies obtained from the compiler have full scope data populated. Span::as_caller_location is now pub(crate) since users should use Body::caller_location instead, which handles inlining correctly.

In favor of passing raw pointers to inline asm.

Keeping up-to-date

…e lint The new handling for non-local macros in `semicolon_in_expressions_from_macros` produces new deny-by-default lints on various existing crates, which have not previously received warnings because prior Rust versions suppressed them. Split those out into a new `semicolon_in_expressions_from_non_local_macros` lint, and make that one warn-by-default (and FCW warn-in-deps), rather than deny-by-default, to give the ecosystem time to adapt. This reintroduces the `is_local` tracking from commit 9192337.

…ros` The automatic mechanism to produce lint examples won't work, since this lint needs a separate crate, so add a `rust,ignore` example and manually provide the compiler output.

This is currently a no-op, but will be useful when const in `global_asm!` can be pointers.

Currently global_asm already have symbol names when using v0 scheme, this makes them obtain symbols with legacy scheme too.

This gives the asm-const code the basic ability to deal wiht pointer and provenances, which lays the ground work for asm_const_ptr. Note that `SymStatic` is not fully removed, a specialized is kept and renamed as `SymThreadLocalStatic`, for `#[thread_local]` statics where CTFE does not support naming. The `#[thread_local]` is unstable feature and it's not clear if we want to support this in `sym`, but removal of it should be a separate PR.

With the previous commit, now we can see there are some code duplication for the handling of `GlobalAlloc` inside backends. Do some clean up to unify them.

CTFE pointers created via type ID, `without_provenance` or pointers to const ZSTs can now be codegenned with all 3 backends. These pointers are generated in the same way as integers.

…_attrs enabled

rust-bors · 2026-07-26T06:31:47Z

💔 Test for 98df6f5 failed: CI. Failed job:

auto - dist-x86_64-mingw (web logs, enhanced plaintext logs)

jhpratt · 2026-07-26T06:33:03Z

@bors retry

Rollup of 25 pull requests Successful merges: - #138618 (Support using const pointers in asm `const` operand) - #157962 (Lower paths to functions in const args as ConstKind::Error) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159174 (Fix implicit_provenance_casts warnings on Xous) - #159179 (enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group) - #159518 (iter: extend step_by specialization to cover StepBy<RangeIter<{integer}>>) - #159673 (bootstrap: forward -fdebug-prefix-map when using cc) - #159700 (Split non-local `semicolon_in_expressions_from_macros` into a separate lint) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159738 (implement `CovariantUnsafeCell`) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #152439 (Fix typos and grammar in library documentation) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159204 (Add support to caller_location to rustc_public) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159676 (Update wasm-component-ld to 0.5.27) - #159695 (proc_macro: Fix cfg_attr inner attrs in file modules) - #159730 (allow accessing the contents of UnsafeCell without going through get) - #159809 (Avoid `#[target_features]`) - #159878 (bootstrap: Remove obsolete option `build.compiletest-use-stage0-libtest`)

rust-bors · 2026-07-26T06:39:26Z

💔 Test for a0dbc4c failed: CI. Failed job:

auto - x86_64-gnu (web logs, enhanced plaintext logs)

jhpratt · 2026-07-26T06:40:29Z

@bors retry

Rollup of 25 pull requests Successful merges: - #138618 (Support using const pointers in asm `const` operand) - #157962 (Lower paths to functions in const args as ConstKind::Error) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159174 (Fix implicit_provenance_casts warnings on Xous) - #159179 (enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group) - #159518 (iter: extend step_by specialization to cover StepBy<RangeIter<{integer}>>) - #159673 (bootstrap: forward -fdebug-prefix-map when using cc) - #159700 (Split non-local `semicolon_in_expressions_from_macros` into a separate lint) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159738 (implement `CovariantUnsafeCell`) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #152439 (Fix typos and grammar in library documentation) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159204 (Add support to caller_location to rustc_public) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159676 (Update wasm-component-ld to 0.5.27) - #159695 (proc_macro: Fix cfg_attr inner attrs in file modules) - #159730 (allow accessing the contents of UnsafeCell without going through get) - #159809 (Avoid `#[target_features]`) - #159878 (bootstrap: Remove obsolete option `build.compiletest-use-stage0-libtest`)

rust-log-analyzer · 2026-07-26T06:41:52Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-07-26T06:47:40Z

💔 Test for 35ca183 failed: CI. Failed job:

auto - x86_64-gnu-llvm-21-1 (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-07-26T07:05:35Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

jhpratt · 2026-07-26T07:12:40Z

@bors retry

rust-bors · 2026-07-26T07:12:51Z

⌛ Testing commit 9e1ee5e with merge 5d48869...

Workflow: https://github.com/rust-lang/rust/actions/runs/30192397483

Rollup of 25 pull requests Successful merges: - #138618 (Support using const pointers in asm `const` operand) - #157962 (Lower paths to functions in const args as ConstKind::Error) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159174 (Fix implicit_provenance_casts warnings on Xous) - #159179 (enable `unreachable_cfg_select_predicates` lint as part of `unused` lint group) - #159518 (iter: extend step_by specialization to cover StepBy<RangeIter<{integer}>>) - #159673 (bootstrap: forward -fdebug-prefix-map when using cc) - #159700 (Split non-local `semicolon_in_expressions_from_macros` into a separate lint) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159738 (implement `CovariantUnsafeCell`) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #152439 (Fix typos and grammar in library documentation) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159204 (Add support to caller_location to rustc_public) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159676 (Update wasm-component-ld to 0.5.27) - #159695 (proc_macro: Fix cfg_attr inner attrs in file modules) - #159730 (allow accessing the contents of UnsafeCell without going through get) - #159809 (Avoid `#[target_features]`) - #159878 (bootstrap: Remove obsolete option `build.compiletest-use-stage0-libtest`)

rust-log-analyzer · 2026-07-26T07:27:56Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-07-26T07:33:39Z

💔 Test for db930f1 failed: CI. Failed job:

try - x86_64-mingw-1 (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-07-26T07:53:16Z

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [run-make] tests\run-make-cargo\amdgpu-lto stdout ----

error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make-cargo\\amdgpu-lto\\rmake.exe"
stdout: none
--- stderr -------------------------------
command failed at line 27
"D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2-tools-bin\\cargo.exe" "build" "--release" "--lib" "--manifest-path" "Cargo.toml" "-Zbuild-std=core" "--target" "amdgcn-amd-amdhsa"
output status: `exit code: 101`
---
    Blocking waiting for file lock on package cache
    Blocking waiting for file lock on package cache
   Compiling compiler_builtins v0.1.160 (D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\src\rust\library\compiler-builtins\compiler-builtins)
   Compiling core v0.0.0 (D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\src\rust\library\core)
   Compiling amdgpu_lto v0.1.0 (D:\a\rust\rust\build\x86_64-pc-windows-gnu\test\run-make-cargo\amdgpu-lto\rmake_out)
error: linking with `rust-lld` failed: exit code: 0xc0000374
  |
  = note: "rust-lld" "-flavor" "gnu" "--version-script=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make-cargo\\amdgpu-lto\\rmake_out\\target\\amdgcn-amd-amdhsa\\release\\deps\\rustcJ6mZpP\\list" "--no-undefined-version" "<1 object files omitted>" "--as-needed" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make-cargo\\amdgpu-lto\\rmake_out\\target\\amdgcn-amd-amdhsa\\release\\deps\\rustcJ6mZpP\\raw-dylibs" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make-cargo\\amdgpu-lto\\rmake_out\\target\\amdgcn-amd-amdhsa\\release\\deps\\amdgpu_lto.elf" "--gc-sections" "-shared" "-O1" "--strip-debug"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: 

error: could not compile `amdgpu_lto` (lib) due to 1 previous error
------------------------------------------

---- [run-make] tests\run-make-cargo\amdgpu-lto stdout end ----

failures:
---
Currently active steps:
test::RunMakeCargo { test_compiler: Compiler { stage: 2, host: x86_64-pc-windows-gnu, forced_compiler: false }, target: x86_64-pc-windows-gnu } at src\bootstrap\src\core\build_steps\test.rs:1965
test::Compiletest { test_compiler: Compiler { stage: 2, host: x86_64-pc-windows-gnu, forced_compiler: false }, target: x86_64-pc-windows-gnu, mode: run-make, suite: "run-make-cargo", path: "tests/run-make-cargo", compare_mode: None } at src\bootstrap\src\core\build_steps\test.rs:1965
Build completed unsuccessfully in 3:02:29
make: *** [Makefile:126: ci-mingw-x] Error 1
  local time: Sun Jul 26 07:33:24 CUT 2026
  network time: Sun, 26 Jul 2026 07:33:24 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

him2him2 and others added 30 commits February 10, 2026 10:21

rustdoc: warn on improperly interleaved HTML/MD

3ffc0fb

rustdoc: add tests for MD/HTML interleaving

cb61eb4

Clean up and test paragraph and table warn

c9be91c

Fix implicit_provenance_casts warnings on Xous

d062ad2

enable UNREACHABLE_CFG_SELECT_PREDICATES lint

e91e00f

Since cfg_select is stable since 1.95, this can be enabled.

html_tags: remove in_code_block no-op branch

9bc15a8

html_tags: rename tags based on camelid's nit

047068a

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

Get rid of expose_provenance on Xous

d3e8e6b

In favor of passing raw pointers to inline asm.

Review comments

7b0af92

Update wasm-component-ld to 0.5.27

10100f2

Keeping up-to-date

Add (manual) example for `semicolon_in_expressions_from_non_local_mac…

c1a4b72

…ros` The automatic mechanism to produce lint examples won't work, since this lint needs a separate crate, so add a `rust,ignore` example and manually provide the compiler output.

stepping into NormalizesTo where-clauses may be productive

66d0fb8

Collect constants within global_asm! in collector

4233b3b

This is currently a no-op, but will be useful when const in `global_asm!` can be pointers.

Add FnDef/Closure -> FnPtr coercion for inline asm const operand

f44536c

Give global_asm symbol names

bf74b6c

Currently global_asm already have symbol names when using v0 scheme, this makes them obtain symbols with legacy scheme too.

Delay stringification of const to backend

b44bea2

Unify handling of GlobalAlloc inside backend

4c39d62

With the previous commit, now we can see there are some code duplication for the handling of `GlobalAlloc` inside backends. Do some clean up to unify them.

Handle pointers with offset for asm const

338d560

Support codegen of asm const pointers without provenance

6deaed5

CTFE pointers created via type ID, `without_provenance` or pointers to const ZSTs can now be codegenned with all 3 backends. These pointers are generated in the same way as integers.

Give codegen units symbol names that backend can use

1fd34e4

Generate unique symbol names if const pointers refer to promoted static

c95d35e

optimization: don't look for diagnostic/canonical items without rustc…

aabf824

…_attrs enabled

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 26, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 26, 2026

Uh oh!

Uh oh!

Conversation

jhpratt commented Jul 26, 2026

Uh oh!

rust-bors Bot commented Jul 26, 2026

Uh oh!

jhpratt commented Jul 26, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 26, 2026

Uh oh!

jhpratt commented Jul 26, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jul 26, 2026

Uh oh!

rust-bors Bot commented Jul 26, 2026

Uh oh!

rust-log-analyzer commented Jul 26, 2026

Uh oh!

jhpratt commented Jul 26, 2026

Uh oh!

rust-bors Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-log-analyzer commented Jul 26, 2026

Uh oh!

rust-bors Bot commented Jul 26, 2026

Uh oh!

rust-log-analyzer commented Jul 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

rust-bors Bot commented Jul 26, 2026 •

edited

Loading