fix ICE in suggest_add_reference_to_arg for non-callable items - #160628
Open
im-lunex wants to merge 1 commit into
Open
fix ICE in suggest_add_reference_to_arg for non-callable items#160628im-lunex wants to merge 1 commit into
suggest_add_reference_to_arg for non-callable items#160628im-lunex wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tcx.fn_sig(def_id)panicked ("unexpected sort of node in fn_sig()") whenthe
def_idin aWhereClauseInExprobligation was the struct beingconstructed, not the impl. This happens when a struct literal argument is
missing a field.
Guard both
fn_sigcall sites insuggest_add_reference_to_argso thesuggestion only fires for callable defs.
Fixes #160591.