User facing .expect now follows “expect as precondition" style - #160792
Merged
Conversation
…recondition” style.
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 9, 2026
…=Mark-Simulacrum User facing .expect now follows “expect as precondition" style Related issue: rust-lang#159751 Updated .expect error message in std/src/net/tcp.rs to follow “expect as precondition" style.
This was referenced Aug 9, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 9, 2026
…uwer Rollup of 9 pull requests Successful merges: - #160782 (rustc_attr_ir: fix up `lang_items` imports) - #159746 (stabilize `c_variadic_naked_functions`) - #160141 (Refactor tidy detection of stability attribute) - #160744 (make more diagnostic structs pub(crate)) - #160778 (Add regression test for cycle error on guaranteed unsized self type) - #160779 (arm64ec: `f128` is supported since LLVM 23) - #160781 (Add regression test for save temps ICE on incremental recompile) - #160792 (User facing .expect now follows “expect as precondition" style) - #160796 (Change .expect message to follow precondition style)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #159751
Updated .expect error message in std/src/net/tcp.rs to follow “expect as precondition" style.