docs(core): correct ARMv8-M Baseline atomic CAS support - #162319
Open
bardiharborow wants to merge 1 commit into
Open
docs(core): correct ARMv8-M Baseline atomic CAS support#162319bardiharborow wants to merge 1 commit into
bardiharborow wants to merge 1 commit into
Conversation
ARMv8-M Baseline targets support CAS operations, but the atomic module docs incorrectly list them as load and store-only. Limit that restriction to ARMv6-M and include thumbv8m.base-* among the targets with full CAS support.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
A-atomic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARMv8-M Baseline targets support CAS operations, but the atomic module docs incorrectly list them as load and store-only.
The incorrect ARMv8-M Baseline comment was introduced in #149241 while updating the atomic portability notes for ARMv4T/ARMv5TE.
Limit that restriction to ARMv6-M and include
thumbv8m.base-*among the targets with full CAS support.@rustbot label +A-docs +A-atomic +O-Arm +T-libs