Skip to content

simplify Target::GenericParam - #162661

Open
mejrs wants to merge 2 commits into
rust-lang:mainfrom
mejrs:genericparam
Open

simplify Target::GenericParam#162661
mejrs wants to merge 2 commits into
rust-lang:mainfrom
mejrs:genericparam

Conversation

@mejrs

@mejrs mejrs commented Sep 11, 2026

Copy link
Copy Markdown
Member

Primary motivation is that i've been greatly annoyed recently by us having 3 enums all named GenericParamKind.

Small change in this PR: generic type parameters can now be marked stable/unstable without having a default, i.e.

struct X<#[unstable(feature = "name", reason = "...", issue = "1337")] T>{t: T}

but this is highly unstable so I don't think it matters

@rustbot

rustbot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 11, 2026
@rustbot

rustbot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 76 candidates
  • Random selection from 19 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants