Three-regime relay consolidation: CC → opt_passive → ff+PID across all VGOSWEC flap variants - #52
Merged
Conversation
… script, update docs
…, typo, table clarity
Copilot
AI
changed the title
[WIP] Finalize controller study for three-controller regime relay
Three-regime relay consolidation: CC → opt_passive → ff+PID across all VGOSWEC flap variants
Jul 11, 2026
salhus
marked this pull request as ready for review
July 11, 2026 21:48
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalizes the simulation study as a clean three-controller regime relay — CC (short periods) → opt_passive (resonance band) → ff+PID (long tail) — across all five flap variants (VGM-0/10/20/45/90), and prunes the degenerate fixed-passive arm. All figures regenerate from committed CSVs via
--plot-only.Degenerate passive pruned
B_pto = B55(ω₀)is 10⁴–10⁵× smaller than|Z_intrinsic(ω₀)|for every flap (VGM-0 at 3.2e-7 N·m·s/rad in the pitch-radiation notch). Passive captures ≈ 0 W across the full band — it adds no signal to the study.analysis/passive/andanalysis/passive_vs_optpassive/deletedconfig/vgoswec_{0,10,20,45,90}_passive.yamlreverted:B_pto: 0.5placeholder +TODO: tune with tank-test data,wave.period: 1.5. Controller type remains usable in code.New:
scripts/three_regime_comparison.pyModeled on
cc_vs_ffpid_comparison.py. Loads CC (analysis/cc/), opt_passive (analysis/opt_passive/), ff+PID (analysis/passive_guarded/) CSVs and produces:masked=trueregions hatchedP_captureover all (controller, flap-angle) at every period; annotated by winning regime bandResonance hump marches with flap angle (key result)
opt_passive matches a tuned feedforward controller at resonance with a single tuning-free coefficient — it does not universally win. ff+PID edges it on high-angle flaps; the honest framing is "ties at resonance."
Docs
analysis/FINDINGS_3REGIME.md(new) — three-regime relay table, per-flap peak table, honest opt_passive vs ff+PID framing, appendix on passive degeneracydocs/CONTROLLERS.md— added three-regime relay section; deprecated passive-vs-opt_passive studyanalysis/FINDINGS.md,README.md— updated reproduction commands and framing