Remove unused <zlib.h> inclusions [minor] #1763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove remaining references to bcf_p1_fp_lk, which has been unused since the undocumented call -K option was removed in 0.1.0-33-gc4172c5. After that, neither source file actually uses anything from <zlib.h>.
Member
|
Thank you |
Member
Author
|
Wow, that was quick! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove remaining references to
bcf_p1_fp_lk, which has been unused since the undocumentedcall -Koption was removed in c4172c5 in 2013.After that, neither source file actually uses anything from
<zlib.h>(vcfcall.c already didn't).Hence somewhat surprisingly bcftools does not directly use zlib itself (it does indirectly via htslib, of course). So the zlib probing etc could in principle be removed from configure.ac and Makefile, but that may not be worth doing at this time.