Fix a divide by zero in cram_xdelta_decode. - #2026
Merged
Merged
Conversation
If word_size is zero we do modulo 0 and caused a divide-by-zero crash. Word size is stored in the input data and so we need to validate this, but it's constant so validation is done in the initialisation function only. We also check for <0 as this has no meaning either. With thanks to Team Atlanta. Co-authored-by: Team Atlanta Signed-off-by: James Bonfield <jkb@sanger.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If word_size is zero we do modulo 0 and caused a divide-by-zero crash. Word size is stored in the input data and so we need to validate this, but it's constant so validation is done in the initialisation function only.
We also check for <0 as this has no meaning either.
With thanks to Team Atlanta.
Co-authored-by: Team Atlanta