fix(override-rules): remove users from useEffect dependency array

[fallenbagel]

Description

Navigating to Settings > Services triggers an infinite request loop to /api/v1/user when override rules with user conditions exist. The useEffect in OverrideRuleTiles that fetches user data includes users in its dependency array, but also calls setUsers within the effect body thus creating a state update → re-run → state update cycle.

This PR removes users from the dependency array so the effect only re-runs when rules change resolves the loop.

• Fixes Settings > Services tab - infinite api/v1/user query loop #2769

How Has This Been Tested?

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Bug Fixes
  • Improved performance in the Override Rule settings by optimizing update behavior for rule handling.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b2dba6d1-fffb-4cf2-8199-110891db7273

📥 Commits

Reviewing files that changed from the base of the PR and between 20c2ed8 and 23e7ee1.

📒 Files selected for processing (1)

• src/components/Settings/OverrideRule/OverrideRuleTiles.tsx

---

📝 Walkthrough

Walkthrough

A useEffect dependency array in the OverrideRuleTiles component was modified from [rules, users] to [rules]. This prevents the effect from re-triggering when the users state updates internally, addressing an infinite API request loop.

Changes

Cohort / File(s)	Summary
useEffect Dependency Fix src/components/Settings/OverrideRule/OverrideRuleTiles.tsx	Removed users from useEffect dependency array to prevent self-triggering infinite loop when fetching users for rules.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A loop spun 'round and 'round all day,
Users fetched in every way,
But one small fix, a tweak so neat,
Made endless requests obsolete! ✨

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing users from a useEffect dependency array to fix the infinite loop issue in override rules.
Linked Issues check	✅ Passed	The PR successfully addresses issue #2769 by removing users from the useEffect dependency array, eliminating the state update cycle causing infinite /api/v1/user requests.
Out of Scope Changes check	✅ Passed	The change is narrowly focused on the identified problem: modifying only the dependency array in OverrideRuleTiles.tsx with no unrelated modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}