refactor(imageproxy): reduce noisy image cache logging

[fallenbagel]

Description

Users without a Jellyfin avatar (where avatarVersion is null) were still triggering a fetch to the Jellyfin server on every avatarproxy request, resulting in unnecessary 404s and noisy debug logs. This skips the Jellyfin request entirely for those users and serves the gravatar fallback directly. Also downgrades the ENOENT error log in clearCache to a silent early return, since the cache directory not existing yet is expected behavior, not an error.

• Fixes Cache]: ENOENT: no such file or directory, scandir #2786

How Has This Been Tested?

• Just log out and log back in when you have recent requests slider with users with no jellyfin avatars and observe no noisy logs

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Bug Fixes
  • Avatar loading now skips unnecessary primary fetches when a user lacks an avatar version, reducing failed requests and improving reliability.
  • Cache-cleanup failures for missing directories no longer produce error logs, reducing noise while preserving logging for other errors.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d4f2e376-3d0c-411c-8b92-d497b506a25d

📥 Commits

Reviewing files that changed from the base of the PR and between 537d988 and 28e94e8.

📒 Files selected for processing (2)

• server/lib/imageproxy.ts
• server/routes/avatarproxy.ts

---

📝 Walkthrough

Walkthrough

Avatar proxy now skips fetching the primary Jellyfin/Emby avatar URL when a user lacks an avatarVersion, using the fallback URL directly; image cache clearing no longer logs an error for missing cache directories (returns early on ENOENT).

Changes

Cohort / File(s)	Summary
Avatar proxy logic server/routes/avatarproxy.ts	Primary avatar fetch is conditional on user?.avatarVersion; if falsy, the route fetches directly from fallbackUrl. Existing ETag/304 and response behavior unchanged.
Image cache ENOENT handling server/lib/imageproxy.ts	ImageProxy.clearCache now returns silently when e.code === 'ENOENT' instead of logging an error; other directory-read errors still log.

Sequence Diagram(s)

sequenceDiagram
  participant Client as Client
  participant Server as Server (avatar proxy)
  participant Primary as Jellyfin/Emby
  participant Fallback as Fallback URL

  Client->>Server: Request avatar (userId)
  Server->>Server: Check user.avatarVersion
  alt avatarVersion exists
    Server->>Primary: Fetch primary avatar URL
    Primary-->>Server: Image or JSON "404"
    alt primary returned usable image
      Server-->>Client: Return image (ETag/304 handling)
    else primary returned JSON or missing
      Server->>Fallback: Fetch fallback image
      Fallback-->>Server: Image
      Server-->>Client: Return image (ETag/304 handling)
    end
  else no avatarVersion
    Server->>Fallback: Fetch fallback image
    Fallback-->>Server: Image
    Server-->>Client: Return image (ETag/304 handling)
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nibble bugs and skip a chase,
If no avatar version, I use fallback's grace,
Silent on missing folders, no frantic cry,
A tidy cache field beneath the sky,
Hop on — the images return, spry! 🥕✨

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'refactor(imageproxy): reduce noisy image cache logging' accurately summarizes the main changes: suppressing unnecessary logging from image cache operations.
Linked Issues check	✅ Passed	The PR addresses issue #2786 by handling the ENOENT error silently in clearCache and optimizing avatar fetching to prevent unnecessary 404s that caused noisy logs.
Out of Scope Changes check	✅ Passed	All changes are directly related to the stated objectives: optimizing avatar proxy requests and reducing noisy cache logging, with no extraneous modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@server/routes/avatarproxy.ts`:
- Around line 145-155: The user.avatarVersion is only saved when the avatar
actually changed, so checkAvatarChanged updates the in-memory avatarVersion but
doesn't persist it which makes avatarproxy's if (user?.avatarVersion) branch
false later; update the login/auth flow where checkAvatarChanged is called so
that after calling checkAvatarChanged you always set user.avatarVersion (from
the check result) and call user.save() regardless of whether changed is true
(i.e., move the save outside the if (changed) block or always persist the
version field) so avatarVersion is always persisted to the DB.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 10568d98-8eac-4dd2-b64e-1df8b8d2fc09

📥 Commits

Reviewing files that changed from the base of the PR and between 4434c45 and 537d988.

📒 Files selected for processing (1)

• server/routes/avatarproxy.ts