refactor(watchlistsync): log media request creation after success instead of before

[fallenbagel]

Description

The "Creating media request" log message fired before MediaRequest.request() was called, so it would appear even when the request was subsequently rejected (e.g. duplicate, quota, no seasons available). This made it look like duplicate requests were being created when they weren't. Moves the log after the successful request call and changes the message to past tense to accurately reflect what happened.

• Fixes request auto-created for watchlist items that already exist (in logs only) #2787

How Has This Been Tested?

(Not required)

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Chores
  • Improved internal logging for media request synchronization from Plex watchlist.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f2e10af9-af7c-44b3-b0c4-5c3767cc244f

📥 Commits

Reviewing files that changed from the base of the PR and between 4434c45 and f1aabec.

📒 Files selected for processing (1)

• server/lib/watchlistsync.ts

---

📝 Walkthrough

Walkthrough

The watchlist sync logging was repositioned to emit "Created media request" messages only after MediaRequest.request() successfully completes, rather than before the request attempt. This ensures logs accurately reflect whether a request was actually created instead of just attempted.

Changes

Cohort / File(s)	Summary
Watchlist Sync Logging server/lib/watchlistsync.ts	Moved "Creating media request from user's Plex Watchlist" log from before MediaRequest.request() invocation to after successful completion, ensuring logs only indicate actual request creation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• fix: preserve blocklist on media deletion & optimise watchlist-sync #2478 — Modifies the same request-creation flow in server/lib/watchlistsync.ts, handling request filtering and related behavior.

Suggested reviewers

• gauthier-th
• 0xSysR3ll

Poem

🐰✨ A hop and a skip, the logs now sing true,
No phantom requests appearing in view!
When media's created, the message appears,
Accurate logging that brings us good cheer! 📜

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: moving the 'Creating media request' log from before the request to after successful completion, changing it to past tense.
Linked Issues check	✅ Passed	The pull request directly addresses issue #2787 by logging media request creation only after successful completion, preventing misleading logs for requests that were rejected.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the logging issue in issue #2787; only the watchlist-sync logging was modified with no unrelated alterations.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}