Do not apply format to non numbers #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @d0b3rm4n Returning the number where you are doing it will make a bunch of other tests fail. |
This addresses the issue seperman#200
d0b3rm4n
force-pushed
the
fix-for-issue-200
branch
from
a158353 to
71a54e3
Compare
Contributor
Author
|
Oh sorry, since I run it on Win10 w/o mmh3 some of the tests anyway failed, so I didn't pay too much attention, my fault. |
Owner
|
@d0b3rm4n Thanks for the PR! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue #200