Skip to content

Do not apply format to non numbers #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Do not apply format to non numbers #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions deepdiff/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,8 @@ def number_to_string(number, significant_digits, number_format_notation="f"):
with localcontext() as ctx:
ctx.prec = len(tup.digits) + tup.exponent + significant_digits
number = number.quantize(Decimal('0.' + '0' * significant_digits))
elif not isinstance(number, numbers):
return number
result = (using % significant_digits).format(number)
# Special case for 0: "-0.00" should compare equal to "0.00"
if set(result) <= ZERO_DECIMAL_CHARACTERS:
Expand Down
12 changes: 12 additions & 0 deletions tests/test_diff_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,15 @@ def test_path_cache(self):
path1 = diff['values_changed'][0].path()
path2 = diff['values_changed'][0].path()
assert 'root[0]' == path1 == path2

def test_bool_str(self):
t1 = {'key1': True}
t2 = {'key1': 'Yes'}
diff = DeepDiff(t1, t2, ignore_type_in_groups=[(bool, str)],
ignore_numeric_type_changes=True)
expected = {'values_changed':
{"root['key1']":
{'new_value': 'Yes', 'old_value': True}
}
}
assert diff == expected