Skip to content

Comments

Update NuGet packages#25403

Closed
paulrouget wants to merge 0 commit intoservo:masterfrom
paulrouget:nugetPkgUp
Closed

Update NuGet packages#25403
paulrouget wants to merge 0 commit intoservo:masterfrom
paulrouget:nugetPkgUp

Conversation

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Dec 30, 2019

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 30, 2019
@paulrouget paulrouget changed the title Update Angle and CppWinRT [WIP] Update Angle and CppWinRT Dec 30, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Dec 30, 2019

I ran into that issue: microsoft/cppwinrt#410

Adding onecore.lib appears to solve the winrt missing symbol issue.

Not tested on device.

@paulrouget paulrouget changed the title [WIP] Update Angle and CppWinRT Update Angle and CppWinRT Dec 30, 2019
@paulrouget paulrouget force-pushed the nugetPkgUp branch 2 times, most recently from dcb4393 to c89e1ff Compare December 30, 2019 08:50
@nox
Copy link
Contributor

nox commented Jan 6, 2020

r? @jdm

@highfive highfive assigned jdm and unassigned nox Jan 6, 2020
@jdm
Copy link
Member

jdm commented Jan 6, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2020

📌 Commit c89e1ff has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jan 6, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2020

⌛ Testing commit c89e1ff with merge ddb67c4...

bors-servo pushed a commit that referenced this pull request Jan 6, 2020
Auto merge of #25403 - paulrouget:nugetPkgUp, r=jdm
ddb67c4 
Update Angle and CppWinRT

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25341 (GitHub issue number if applicable)
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2020

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jan 6, 2020
@jdm
Copy link
Member

jdm commented Jan 6, 2020 

     3>XamlMetaDataProvider.obj : error LNK2001: unresolved external symbol WINRT_GetErrorInfo [C:\Users\task_1578310905\repo\support\hololens\ServoApp\ServoApp.vcxproj]
     3>Servo.obj : error LNK2001: unresolved external symbol WINRT_GetErrorInfo [C:\Users\task_1578310905\repo\support\hololens\ServoApp\ServoApp.vcxproj]
     3>ServoControl.obj : error LNK2001: unresolved external symbol WINRT_GetErrorInfo [C:\Users\task_1578310905\repo\support\hololens\ServoApp\ServoApp.vcxproj]
     3>XamlTypeInfo.Impl.g.obj : error LNK2001: unresolved external symbol WINRT_GetErrorInfo [C:\Users\task_1578310905\repo\support\hololens\ServoApp\ServoApp.vcxproj]
     3>XamlTypeInfo.g.obj : error LNK2001: unresolved external symbol WINRT_GetErrorInfo [C:\Users\task_1578310905\repo\support\hololens\ServoApp\ServoApp.vcxproj]
     3>App.obj : error LNK2001: unresolved external symbol WINRT_GetErrorInfo [C:\Users\task_1578310905\repo\support\hololens\ServoApp\ServoApp.vcxproj]
     3>BrowserPage.obj : error LNK2001: unresolved external symbol WINRT_GetErrorInfo [C:\Users\task_1578310905\repo\support\hololens\ServoApp\ServoApp.vcxproj]
     3>module.g.obj : error LNK2001: unresolved external symbol WINRT_GetErrorInfo [C:\Users\task_1578310905\repo\support\hololens\ServoApp\ServoApp.vcxproj]
     3>OpenGLES.obj : error LNK2001: unresolved external symbol WINRT_GetErrorInfo [C:\Users\task_1578310905\repo\support\hololens\ServoApp\ServoApp.vcxproj]

@jdm
Copy link
Member

jdm commented Jan 6, 2020

We're missing onecore.lib for the arm64 linking arguments.

@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2020

☔ The latest upstream changes (presumably #25509) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Jan 13, 2020
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Feb 10, 2020
@paulrouget paulrouget changed the title Update Angle and CppWinRT Update NuGet packages Feb 10, 2020
@paulrouget
Copy link
Contributor Author

paulrouget commented Feb 10, 2020

Angle has been updated separately.
I haven’t tested on device.

@jdm jdm removed the S-needs-rebase There are merge conflict errors. label Feb 10, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Feb 10, 2020

☔ The latest upstream changes (presumably #25716) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Feb 10, 2020
@paulrouget paulrouget removed the S-needs-rebase There are merge conflict errors. label Feb 11, 2020
@jdm jdm mentioned this pull request Feb 12, 2020
Closed
@dralley
Copy link
Contributor

dralley commented Apr 12, 2020

Is anything blocking this, or does it just need a fresh passing test run?

@jdm
Copy link
Member

jdm commented Apr 12, 2020

It needs testing.

@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2020

☔ The latest upstream changes (presumably #25853) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Apr 19, 2020
@jdm jdm closed this Apr 20, 2020
@jdm jdm mentioned this pull request Apr 20, 2020
Merged
bors-servo added a commit that referenced this pull request Apr 29, 2020
@bors-servo
Auto merge of #26230 - jdm:nugetPkgUp, r=Manishearth
e94e341 
Update Winrt and xrloader and ANGLE NuGet packages.

Rebase of #25403. Tested against latest master revision on device.
bors-servo added a commit that referenced this pull request Apr 29, 2020
@bors-servo
Auto merge of #26230 - jdm:nugetPkgUp, r=Manishearth
1fa058d 
Update Winrt and xrloader and ANGLE NuGet packages.

Rebase of #25403. Tested against latest master revision on device.
bors-servo added a commit that referenced this pull request Apr 29, 2020
@bors-servo
Auto merge of #26230 - jdm:nugetPkgUp, r=Manishearth
28d2cbf 
Update Winrt and xrloader and ANGLE NuGet packages.

Rebase of #25403. Tested against latest master revision on device.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdm jdm

Labels

S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to UWP Angle 2.1.17 package

6 participants

@paulrouget @nox @jdm @bors-servo @dralley @highfive