Meeting 2015 06 01

Servo Meeting 2015-06-01

Vidyo links:

jack: We've pretty much moved to Reviewable. Any objections to turning off Critic's auto-comment notifications?
Manishearth: Ms2ger still prefers Critic because of Reviewable perf issues in Firefox. Maybe he can feed the PRs to Critic manually?
mbrubeck: It's confusing to newcomers. highfive, critic bot, reviewable...
jack: I'll see what our options are for turning off Critic stuff while keeping it as a backup option. And talk Reviewable into making it better in Firefox.

jack: I noticed #6180, which seems to be in limbo. Do we need to redo it, or land it regardless of the upgrade...
jdm: There's at least one bit that needs to land; that can happen before or after the SM upgrade. It blocks turning on the jQuery test suite. I could extract just that bit and do that independently.
jack: Is the rest of it obsoleted by mwu's SM upgrade?
jdm: It's unclear.
jack: I saw you finished the review of the SMup. It looked like there were a lot of comments.
jdm: Yes, but a lot of them should be easily resolved. There's some important stuff, but I don't see any fundamental problems.
jack: Can we land this before you leave on vacation?
jdm: I'm pretty sure Ms2ger and nox can handle any follow-up reviews while I'm gone.
jack: Do you want to extract the jQuery-test-blocking bits into a separate PR? And should the rest remain open in the current PR for now?
jdm: Yeah.

jack: I saw Manishearth did another Rust upgrade. W
Manishearth: This one gets us a performance improvement for derive that I added a couple of weeks ago.
jack: In terms of library changes, are there any breaking changes?
Manishearth: Just one change to plugins, which is related to the perf improvement.

jack: I had a conversation with larsberg and aturon and edunham about what Rust devops needs, and one item is making our Rust snapshots buildable by people other than Lars.
brson: Can we even consolidate Rust and Servo's snapshotting systems?
jack: Sounds good to me. I believe we build slightly more stuff than you do; I think previously there were some issues about running tests on the same machines used for build.
Manishearth: We include some cross-toolchains that Rust doesn't have by default.
brson: That's okay; we want those as well.
SimonSapin: I think the reason we're not using nightly builds is that we need cross-compiler support.
jack: Including Mac->Android and Linux32->Android.

SimonSapin: There's a profiler extension for Firefox that works even in release. The output is difficult, but if someone wants to look at that output, we could suggest ways to improve reviewable.
jack: I suspect some complaints are due to large reviews, which by necessity are more complex than small reviews.
jdm: Can you send me links to some profiles you've captured?
SimonSapin: Yes.
jack: What is Rust using for code review? GitHub? Do you find "comment on outdated diff" a problem?
brson: We just live with it. No one has really complained.
SimonSapin: Is it common for Rust PRs to get rebased/rewritten?
bson: Yes, we do encourage rebasing.
SimonSapin: Do you see "commented on outdated diff" a lot?
brson: Yes.

jack: Colin will be working with larsberg on power management. Laleh is returning and will be working on scheduling-related things in one or more areas, also with larsberg.
azita: Do we plan to bring in more researchers this year, or is that it?
jack: I don't know; I don't have anybody in mind currently, but if someone showed up then we could see.