Skip to content

Workweek governance

Jump to bottom
jdm edited this page Nov 11, 2014 · 1 revision

Servo governance

  • mbrubeck: Need to decide on a module owner and peers. larsberg and jack as module owners?

  • jdm: There can be only one.

  • jack: How many peers?

  • mbrubeck: Tons. Those are the people who can approve things.

  • larsberg: This just became too much work.

  • mbrubeck: Wiki page, dev-governance e-mail...

  • jack: Every time you make a change?

  • larsberg: I'm more concerned about giving people r+ and agreements.

  • jdm: Checking in code is OK. But giving people r+ = signing a license agreement.

  • larsberg: So, do manish, martin, etc. need to sign this form?

  • mbrubeck: https://www.mozilla.org/en-US/about/governance/policies/commit/

  • mbrubeck: That page has stuff about filing bugs to get access for the mercurial server (not relevant to us), but the form is generic.

  • jdm: There are no stated policies for things outside of mozilla source control.

  • zwarich: Rust requires agreements from people.

  • jack: I don't think so.

  • jdm: It did at some point... but I don't know how often they give out r+ abilities.

  • larsberg: Who should we ask?

  • jdm: Gervase Markham (gerv). BTW, anyone with the ability to commit code in Firefox needs to have signed a form thing, even Mozilla Staff.

  • zwarich: That's because generally our privs are associated with a github account, so that permission sticks with you outside of employment.

  • yichoi: I did an agreement one year ago with Brendan. It conflicted with the samsung policy, so we might have to check this agreement again.

  • jack: Should be easy to do. We have a list in bors and one in github.

  • zwarich: Can we sync the list of owners in bors with the owners in github?

  • jack: Someone added that feature to bors, but in the middle of a bunch of other broken bors features.

  • larsberg: Maybe we can cherry-pick that fix to use the owners list. We need to pick up a fix for the links to PRs on bors.html anyway.

  • jack: Seems weird about the PRs... not broken on Rust.

  • larsbeg: Anything to change with bors?

  • jack: Seems to be working well. How long is cycle time?

  • larsberg: 25 minutes. Maybe can shorten it.

  • jdm: Governance topic. What's the policy for becoming a commiter?

  • jack: How does it work in firefox?

  • jdm: People file a bug (or have one filed for them) and then they need two module owners or peers to vouch for them.

  • jack: How do people who are peers decide to vouch for them? What are they saying?

  • jdm: The peer is saying they believe in the person being vouched for. In bad cases where access is revoked, it reflects badly on the peer.

  • jack: Has it ever been revoked?

  • jdm: I don' t think so.

  • bruno: In WebKit, they have to ask on the mailing list, and if two people with commit agree, then it is added.

  • mbrubeck: It's rare for this to be controversial, but the process is just there to resolve issues.

  • zwarich: Two levels in WebKit: reviewers and committers. There was contention for if someone could be promoted to reviewer, since that is people who can directly commit. No distinction in Servo, really.

  • mbrubeck: Code should be reviewed by a peer. Reviews can be delegated.

  • zwarich: Biggest thing we worried about was people reviewing code that was not in their area. In Servo it's weird because every week everything changes. Everybody reviews everything, except for some specific layout/graphics/DOM stuff.

  • jack: So we'd ask people to do test reviews before they can merge?

  • martin: That's what we did on WebKit. People would look at their pre-reviews.

  • larsberg: That's how manish got started.

  • mbrubeck: Not just for volunteers; also for new employees.

  • zwarich: Probably don't need to be too formal about it.

  • jdm: Just write down somewhere in our documentation that if you're interested in having review responsibilities, you should talk with us.

  • zwarich: Definitely should state it somewhere. It can be a little confusing on some other projects (like Rust). Most of the problems you run into happen when lots of people are shipping lots of products on your software.

  • simonsapin: It would be good to have this written down somewhere.

  • larsberg: I'll handle writing up a wiki page on this and talking with gerv.

  • jack: Then we can get people in December, including manish.

  • jdm: He has one already!

  • mbrubeck: Yes, the Firefox one is just a generic Mozilla license / agreement.

Clone this wiki locally