Skip to content

feat: chart styles and loading state#6655

Merged
gomesalexandre merged 74 commits intodevelopfrom
loading-state
Apr 12, 2024
Merged

feat: chart styles and loading state#6655
gomesalexandre merged 74 commits intodevelopfrom
loading-state

Conversation

@reallybeard
Copy link
Copy Markdown
Contributor

@reallybeard reallybeard commented Apr 9, 2024

Description

  • Loading state for new chart component
  • Styles for the charts
  • Chart header component

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #

Risk

High Risk PRs Require 2 approvals

low risk

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Engineering

Operations

The chart should show a loading state when its loading data.

When you scrub over the chart, the data should be displayed with the amount and date in the top left corner.

Screenshots (if applicable)

woodenfurniture and others added 30 commits April 2, 2024 19:59
@woodenfurniture
Merge branch 'main' into develop
4513c3b
@gomesalexandre
feat: regenerate asset data 04/02/2024 (#6620)
bd20bf0
@gomesalexandre
feat: disable sym deposits after RUNE (#6622)
88ab918
@gomesalexandre
fix: don't bork asset generation on idle API failures (#6619)
b1e3490
@0xApotheosis
feat: collect 0x trade surplus (#6625)
ca37e0e
@reallybeard @gomesalexandre
feat: bottom sheet dialog (#6623)
76119c8 
* add bottom sheet dialog

* try out vaul

* hook up send

* Create SubPage.tsx

* adjusting dialog header

* Update DialogCloseButton.tsx

* add new action menu

* updates

* update more height stuff

* use 100dvh instead of vh

* use 100vh

* anchor footer at the bottom of the screen

* update new asset search

* Update SelectAssets.tsx

* add min height for regular modals

* Update MobileNavBar.tsx

* remove extra stuff not needed for PR

* remove more stuff not for this PR

* Update AddressInput.tsx

* Update AddressInput.tsx

* Update Dialog.tsx

* Update SelectAssets.tsx

* fix for dialog height

* Update AssetSearch.tsx

---------

Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
@kaladinlight
chore: use unchained proxy endpoints over nownodes proxy (#6606)
faa414f
@0xApotheosis @kaladinlight
feat: use proxy validation endpoint (#6626)
f1f0d1b 
* feat: use proxy validation endpoint

* chore: improve fn name

* update endpoint

* fix: csp

* fix: tests

* chore: use shapeshift proxy csp

* chore: fail open

---------

Co-authored-by: kaladinlight <35275952+kaladinlight@users.noreply.github.com>
@gomesalexandre
feat: many migrations (#6631)
ced5a38
@reallybeard
fix: remove portal on account dropdown (#6635)
939320c 
* account down remove portal

* Update StepRow.tsx
@gomesalexandre
feat: cow affiliate fees (#6621)
4844a2c
@firebomb1 @Jpanam
@yukiwaki @guiribabrb @MarkusMeyer1 @ByRomko @tonyjiang12399
chore: update app translations (#6638)
e038343 
* chore: invalidate outdated translations

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

---------

Co-authored-by: Hellhound13 <hellhound13@gmx.at>
Co-authored-by: Jpanam <jorgepana26@hotmail.com>
Co-authored-by: yuki <yuki@beyondclub.xyz>
Co-authored-by: guiribabrb <guilherme.rb.barbosa@gmail.com>
Co-authored-by: Markus Meyer <djarmy@gmail.com>
Co-authored-by: Romko <29romko29@gmail.com>
Co-authored-by: tonyjiang12399 <327904087@qq.com>
@gomesalexandre
feat: cow quote/unsigned order build cleanup (#6639)
8967dcd 
* feat: getFullAppData tests

* feat: cow quote/unsigned order build cleanup
@gomesalexandre
fix: deep merge opportunities accounts (#6627)
340c9fc
@gomesalexandre @actions-user
feat: regenerate asset data 04/04/2024 (#6636)
43db1bb 
Co-authored-by: GitHub Action <action@github.com>
@gomesalexandre
fix: defi aggregated opportunities uniqBy id first (#6628)
88b3612 
* fix: zapperAssetToMaybeAssetId handle base-token as native asset

* fix: filter unique opportunities by id first

* Revert "fix: zapperAssetToMaybeAssetId handle base-token as native asset"

This reverts commit 1ed1a59.
@gomesalexandre
feat: lending loan summary repayment lock (#6642)
62d6160
@gomesalexandre
fix: mobile dashboard routing (#6637)
ef740bb
@gomesalexandre
feat: thorchain lp disable max deposits (#6645)
0bfb6ba
@gomesalexandre
feat: uni-v2 pools static generation (#6629)
0da4bb9 
* feat: uni-v2 pools static generation

* feat: revert DynamicLpAssets flag

* feat: regen

* feat: cleanup asset upserty bits

* feat: regen
@0xApotheosis
Merge branch 'main' into develop
43fb92c
@gomesalexandre
feat: regenerate asset data 04/08/2024 (#6648)
60aab31
@gomesalexandre
[skip-ci] wip: thorchain LP charts
3e0fa6a
@gomesalexandre
[skip ci]: chore: don't trigger CI
398bb99
@gomesalexandre
[skip ci] feat: handle volume
8b9fcbe
@gomesalexandre
[skip ci] feat: tackle all timeframe
ec75671
@gomesalexandre
[skip ci] fix: all types
f001350
@gomesalexandre
[skip ci] feat: cleanup
fa2ae82
@gomesalexandre
[skip ci] wip: price format
c1a827f
@gomesalexandre
feat: programmatic
864cc8b
@reallybeard reallybeard requested a review from a team as a code owner April 9, 2024 20:34
@reallybeard reallybeard marked this pull request as draft April 9, 2024 20:40
@reallybeard reallybeard marked this pull request as ready for review April 11, 2024 16:32
gomesalexandre
gomesalexandre reviewed Apr 11, 2024
View reviewed changes
Comment thread package.json Outdated
gomesalexandre
gomesalexandre reviewed Apr 11, 2024
View reviewed changes
Comment thread src/components/SimpleChart/ChartHeader.tsx
gomesalexandre
gomesalexandre reviewed Apr 11, 2024
View reviewed changes
Comment thread src/components/SimpleChart/SimpleChart.tsx
gomesalexandre
gomesalexandre reviewed Apr 11, 2024
View reviewed changes
Comment thread src/components/SimpleChart/ChartHeader.tsx Outdated
gomesalexandre
gomesalexandre reviewed Apr 11, 2024
View reviewed changes
Comment thread src/components/SimpleChart/ChartHeader.tsx Outdated
gomesalexandre
gomesalexandre reviewed Apr 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against develop:

  • Selecting week liquidity chart will rug us and render the wrong series:
image
  • Loading states are happy
Screen.Recording.2024-04-11.at.22.50.34.mov

gomesalexandre
gomesalexandre approved these changes Apr 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments have been tackled, and confirmed the week visual change isn't a regression, get in

@gomesalexandre gomesalexandre enabled auto-merge (squash) April 12, 2024 12:46
@gomesalexandre gomesalexandre merged commit c4c9f4f into develop Apr 12, 2024
@gomesalexandre gomesalexandre deleted the loading-state branch April 12, 2024 12:51
0xApotheosis pushed a commit that referenced this pull request Apr 15, 2024
@reallybeard @0xApotheosis
feat: chart styles and loading state (#6655)
d169ae2
@0xApotheosis 0xApotheosis mentioned this pull request Apr 16, 2024
Merged
0xApotheosis added a commit that referenced this pull request Apr 16, 2024
@0xApotheosis @woodenfurniture
@gomesalexandre @reallybeard @kaladinlight @firebomb1 @Jpanam @yukiwaki @guiribabrb @MarkusMeyer1 @ByRomko @tonyjiang12399 @actions-user
feat: use WarningAcknowledgement component (#6647)
e6265e7 
* feat: regenerate asset data 04/02/2024 (#6620)

* feat: disable sym deposits after RUNE (#6622)

* fix: don't bork asset generation on idle API failures (#6619)

* feat: collect 0x trade surplus (#6625)

* feat: bottom sheet dialog (#6623)

* add bottom sheet dialog

* try out vaul

* hook up send

* Create SubPage.tsx

* adjusting dialog header

* Update DialogCloseButton.tsx

* add new action menu

* updates

* update more height stuff

* use 100dvh instead of vh

* use 100vh

* anchor footer at the bottom of the screen

* update new asset search

* Update SelectAssets.tsx

* add min height for regular modals

* Update MobileNavBar.tsx

* remove extra stuff not needed for PR

* remove more stuff not for this PR

* Update AddressInput.tsx

* Update AddressInput.tsx

* Update Dialog.tsx

* Update SelectAssets.tsx

* fix for dialog height

* Update AssetSearch.tsx

---------

Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>

* chore: use unchained proxy endpoints over nownodes proxy (#6606)

* feat: use proxy validation endpoint (#6626)

* feat: use proxy validation endpoint

* chore: improve fn name

* update endpoint

* fix: csp

* fix: tests

* chore: use shapeshift proxy csp

* chore: fail open

---------

Co-authored-by: kaladinlight <35275952+kaladinlight@users.noreply.github.com>

* feat: many migrations (#6631)

* fix: remove portal on account dropdown (#6635)

* account down remove portal

* Update StepRow.tsx

* feat: cow affiliate fees (#6621)

* chore: update app translations (#6638)

* chore: invalidate outdated translations

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

* Translate main.json via GitLocalize

---------

Co-authored-by: Hellhound13 <hellhound13@gmx.at>
Co-authored-by: Jpanam <jorgepana26@hotmail.com>
Co-authored-by: yuki <yuki@beyondclub.xyz>
Co-authored-by: guiribabrb <guilherme.rb.barbosa@gmail.com>
Co-authored-by: Markus Meyer <djarmy@gmail.com>
Co-authored-by: Romko <29romko29@gmail.com>
Co-authored-by: tonyjiang12399 <327904087@qq.com>

* feat: cow quote/unsigned order build cleanup (#6639)

* feat: getFullAppData tests

* feat: cow quote/unsigned order build cleanup

* fix: deep merge opportunities accounts (#6627)

* feat: regenerate asset data 04/04/2024 (#6636)

Co-authored-by: GitHub Action <action@github.com>

* fix: defi aggregated opportunities uniqBy id first (#6628)

* fix: zapperAssetToMaybeAssetId handle base-token as native asset

* fix: filter unique opportunities by id first

* Revert "fix: zapperAssetToMaybeAssetId handle base-token as native asset"

This reverts commit 1ed1a59.

* feat: lending loan summary repayment lock (#6642)

* fix: mobile dashboard routing (#6637)

* feat: thorchain lp disable max deposits (#6645)

* feat: uni-v2 pools static generation (#6629)

* feat: uni-v2 pools static generation

* feat: revert DynamicLpAssets flag

* feat: regen

* feat: cleanup asset upserty bits

* feat: regen

* feat: regenerate asset data 04/08/2024 (#6648)

* feat: thorchain LP charts (#6624)

* feat: tag foxy as expired opportunity (#6651)

* fix: empty my position pools page (#6656)

Update YourPositions.tsx

* feat: add first pass WarningAcknowledgement component

* chore: use translations

* chore: wire up savers deposit

* chore: tidy

* feat: use warningAcknowledgement in trade quote confirm

* feat: use warningAcknowledgement in trade quote confirm

* feat: use warningAcknowledgement in trade lp deposit

* fix: trade quote input warning logic

* chore: use dimmed background

* chore: component a little closer to mock

* chore: component tweaks

* chore: style fixes

* chore: use cancel translation

* fix: trade confirm warning

* Update WarningAcknowledgement.tsx

* Update WarningAcknowledgement.tsx

* feat: chart styles and loading state (#6655)

* fix: thor token repayments (#6676)

* fix: don't render back button on modals initial routes (#6675)

* chore: use translations & constants

* chore: address review feedback

* fix: unbork trade widget size

* fix: show minimum trade amount when unsafe

* fix: trade confirm width

* chore: trigger CI

* fix: typo

* chore: extract motion style to constant

* fix: add no min fallback message

---------

Co-authored-by: woodenfurniture <125113430+woodenfurniture@users.noreply.github.com>
Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
Co-authored-by: reallybeard <89934888+reallybeard@users.noreply.github.com>
Co-authored-by: kevin <35275952+kaladinlight@users.noreply.github.com>
Co-authored-by: firebomb1 <88804546+firebomb1@users.noreply.github.com>
Co-authored-by: Hellhound13 <hellhound13@gmx.at>
Co-authored-by: Jpanam <jorgepana26@hotmail.com>
Co-authored-by: yuki <yuki@beyondclub.xyz>
Co-authored-by: guiribabrb <guilherme.rb.barbosa@gmail.com>
Co-authored-by: Markus Meyer <djarmy@gmail.com>
Co-authored-by: Romko <29romko29@gmail.com>
Co-authored-by: tonyjiang12399 <327904087@qq.com>
Co-authored-by: GitHub Action <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@reallybeard @gomesalexandre @woodenfurniture @0xApotheosis @kaladinlight @firebomb1