Turn on pseudolocalization in the SampleApp - #166
Merged
Conversation
Contributor
Author
|
[Claude Opus 5 (1M context)] Consulted Devin on 2026-09-03 16:31 UTC up to commit |
L10nSharp gained qps-ploc pseudolocalization support in #158, but nothing in the repo showed it working. Set LocalizationManager.OfferPseudoLocalization in the SampleApp so "Pseudo-English (qps-ploc)" appears in its language combo, and point the CHANGELOG entry at the sample app. The comment on the flag explains what the pseudo-locale is for, and notes one non-obvious consequence: while it is selected, the app's "Get Name Dynamically" demo no longer harvests its string into the English XLIFF, because pseudo lookups return before the collection step. That is intended and documented in Pseudo/README.md, but the sample app is read as documentation, so it belongs where someone trying the demo will see it. No library code changes; only the sample app opts in. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
andrew-polk
force-pushed
the
pseudoloc-in-sample-app
branch
from
September 3, 2026 16:33
7f7e648 to
70faa69
Compare
andrew-polk
marked this pull request as ready for review
September 3, 2026 16:33
tombogle
approved these changes
Sep 3, 2026
tombogle
left a comment
tombogle
left a comment
Contributor
There was a problem hiding this comment.
@tombogle reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on andrew-polk).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
L10nSharp gained
qps-plocpseudolocalization support in #158, but nothing in the repo shows it working. A developer evaluating the feature — or a tester told their app can now run in "Pseudo-English" — has no way to see what it looks like short of wiring it into their own application, and the repo has no end-to-end exercise of the pseudo-locale reaching the parts of a real WinForms app that are easiest to get wrong.Fix
Turn the feature on in the SampleApp, which exists precisely to demonstrate L10nSharp's features:
src/SampleApp/Program.cssetsLocalizationManager.OfferPseudoLocalization = trueduring localization setup, so "Pseudo-English (qps-ploc)" appears in the app's UI-language combo alongside English.Pseudo/README.md). The sample app is read as documentation, so that belongs where someone trying the demo will see it.CHANGELOG.mdgains a few words pointing at the SampleApp.No library code changes — the lookup support already worked; only the sample app opts in.
Verified by running the app: selecting the pseudo-locale pseudolocalizes the window title, designer-created controls (labels, buttons, ListView and DataGridView column headers), the format-string label — with its
{0}/{1}substitutions correctly passing through untouched — and theGetDynamicStringresult. The sample now doubles as a quick manual check of the paths most likely to regress.Devin review
This change is