Skip to content

ACU: support commanding of HVAC systems#1085

Merged
mhasself merged 2 commits into
mainfrom
mhasself/acu-hvac-cmd
Jul 17, 2026
Merged

ACU: support commanding of HVAC systems#1085
mhasself merged 2 commits into
mainfrom
mhasself/acu-hvac-cmd

Conversation

@mhasself

Copy link
Copy Markdown
Member

Description

Adds a task to change states of Fans, Boosters, and Heater.

Motivation and Context

Need to change these. Due to changes in commanding (#1055), it's not easy to run shell scripts that command the ACU for this purpose, as the Agent effectively locks out other http command connections.

How Has This Been Tested?

Tested extensively in simulator and also on the LAT a few weeks ago. Commanding this fields is somewhat unreliable, which is not completely understood; but the present changes are unlikely to degrade normal performance of the Agent, even if a few tweaks are going to be needed going forward.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman

Copy link
Copy Markdown
Member

Just a quick comment here that if you merge in the latest main (or rebase before review) that should fix the failing docs build.

@BrianJKoopman BrianJKoopman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question about the target names. Will wait until the group of #1085, #1086, and #1087 are all ready before merging.

Comment thread socs/agents/acu/agent.py
@mhasself
mhasself merged commit e4c3378 into main Jul 17, 2026
15 checks passed
@mhasself
mhasself deleted the mhasself/acu-hvac-cmd branch July 17, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants