ACU: move status_keys into socs#1087
Merged
Merged
Conversation
6 tasks
Member
Sorry, I'm not quite following here (I just don't see matching commit hashes here is all -- edit: well the HVAC ones match, the power one doesn't). Does this contain all of #1085 and #1086? So you'd want to merge those separately, and then drop ca7cc86 and 262e3f1 here during a rebase? |
BrianJKoopman
self-requested a review
July 16, 2026 21:45
BrianJKoopman
approved these changes
Jul 16, 2026
BrianJKoopman
left a comment
Member
There was a problem hiding this comment.
Looks good. I compared to the other PRs and answered my own question there. Happy to handle the merge how ever you'd like (or let you hit the button). Comments on the HVAC and power changes are in their respective PRs.
It makes more sense to keep these definitions near the Agent.
mhasself
force-pushed
the
mhasself/acu-status-keys
branch
from
July 17, 2026 15:46
bf10117 to
f0ec99c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This moves the "status_keys" submodule from soaculib, into the ACU agent codebase.
Note this PR includes code from #1085 and #1086 (can rebase). I'd prefer each PR to go in separately (or otherwise not be squashed in the history).
Motivation and Context
Rationale documented in corresponding soaculib PR; simonsobs/soaculib#47.
How Has This Been Tested?
Tested with ACU simulator. This is low risk, given the simplicity of the module in question.
Types of changes
Checklist: