Skip to content

ACU: move status_keys into socs#1087

Merged
mhasself merged 1 commit into
mainfrom
mhasself/acu-status-keys
Jul 17, 2026
Merged

ACU: move status_keys into socs#1087
mhasself merged 1 commit into
mainfrom
mhasself/acu-status-keys

Conversation

@mhasself

Copy link
Copy Markdown
Member

Description

This moves the "status_keys" submodule from soaculib, into the ACU agent codebase.

Note this PR includes code from #1085 and #1086 (can rebase). I'd prefer each PR to go in separately (or otherwise not be squashed in the history).

Motivation and Context

Rationale documented in corresponding soaculib PR; simonsobs/soaculib#47.

How Has This Been Tested?

Tested with ACU simulator. This is low risk, given the simplicity of the module in question.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman

BrianJKoopman commented Jul 16, 2026

Copy link
Copy Markdown
Member

Note this PR includes code from #1085 and #1086 (can rebase). I'd prefer each PR to go in separately (or otherwise not be squashed in the history).

Sorry, I'm not quite following here (I just don't see matching commit hashes here is all -- edit: well the HVAC ones match, the power one doesn't). Does this contain all of #1085 and #1086? So you'd want to merge those separately, and then drop ca7cc86 and 262e3f1 here during a rebase?

@BrianJKoopman
BrianJKoopman self-requested a review July 16, 2026 21:45

@BrianJKoopman BrianJKoopman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I compared to the other PRs and answered my own question there. Happy to handle the merge how ever you'd like (or let you hit the button). Comments on the HVAC and power changes are in their respective PRs.

It makes more sense to keep these definitions near the Agent.
@mhasself
mhasself force-pushed the mhasself/acu-status-keys branch from bf10117 to f0ec99c Compare July 17, 2026 15:46
@mhasself
mhasself merged commit 37cd849 into main Jul 17, 2026
15 checks passed
@mhasself
mhasself deleted the mhasself/acu-status-keys branch July 17, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants