Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • added gpt-5.1

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Nov 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Building Building Preview Comment Nov 15, 2025 7:23am

@waleedlatif1 waleedlatif1 merged commit f8070f9 into staging Nov 15, 2025
3 of 4 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/models branch November 15, 2025 07:23
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 15, 2025

Greptile Overview

Greptile Summary

This PR claims to add GPT-5.1 model support, but GPT-5.1 doesn't exist - OpenAI has not announced this model. The implementation adds 8 model variants (gpt-5.1, gpt-5.1-mini, gpt-5.1-nano, gpt-5.1-codex, and their Azure equivalents) with pricing, capabilities, and test coverage.

Critical Issues:

  • All GPT-5.1 model definitions reference non-existent models
  • PR metadata incorrectly marked as "Bug fix" when adding new features
  • Reasoning effort inconsistency: GPT-5.1 uses 'none' while GPT-5 uses 'minimal'
  • Documentation formatting issues with Anthropic model names

Recommendation: Verify with OpenAI whether GPT-5.1 exists before merging. If this is placeholder code for future models, it should be clearly documented.

Confidence Score: 0/5

  • This PR is NOT safe to merge - it adds support for non-existent models that will cause runtime failures
  • Score of 0 reflects critical issues: GPT-5.1 doesn't exist in OpenAI's model catalog, making all 8 added model variants non-functional. Users selecting these models will encounter API errors. The PR is also mislabeled as a "Bug fix" when it's actually adding new features. While the code structure and tests are well-written, they're based on invalid model specifications.
  • apps/sim/providers/models.ts needs immediate attention - all GPT-5.1 model definitions must be verified or removed. apps/docs/content/docs/en/blocks/agent.mdx contains incorrect model references. apps/sim/blocks/blocks/agent.ts has reasoning effort inconsistency.

Important Files Changed

File Analysis

Filename Score Overview
apps/sim/providers/models.ts 0/5 Added 8 non-existent gpt-5.1 model variants (including Azure variants) with pricing and capabilities - these models haven't been announced by OpenAI
apps/docs/content/docs/en/blocks/agent.mdx 1/5 Updated documentation to reference non-existent GPT-5.1 model and incorrectly formatted Anthropic model names
apps/sim/blocks/blocks/agent.ts 2/5 Added 'none' to reasoning effort dropdown, creating inconsistency with existing GPT-5 models which use 'minimal'
apps/sim/providers/utils.test.ts 3/5 Added comprehensive test coverage for new gpt-5.1 models, but tests are based on non-existent models

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Models as models.ts
    participant Agent as agent.ts Block
    participant Docs as Documentation
    participant Tests as Test Suite
    
    Dev->>Models: Add GPT-5.1 model definitions
    Models-->>Models: Define 4 OpenAI variants<br/>(gpt-5.1, mini, nano, codex)
    Models-->>Models: Define 4 Azure variants<br/>(azure/gpt-5.1, mini, nano, codex)
    Models-->>Models: Set pricing and capabilities<br/>(reasoningEffort: none/low/medium/high)
    
    Dev->>Agent: Update reasoning effort options
    Agent-->>Agent: Add 'none' option to dropdown
    Note over Agent: Creates inconsistency:<br/>GPT-5 uses 'minimal',<br/>GPT-5.1 uses 'none'
    
    Dev->>Docs: Update model documentation
    Docs-->>Docs: Add GPT-5.1 to model list
    Docs-->>Docs: Update Anthropic/Other providers
    
    Dev->>Tests: Add test coverage
    Tests-->>Tests: Add to unsupported temperature list
    Tests-->>Tests: Add to reasoning effort tests
    Tests-->>Tests: Add to verbosity tests
    
    Note over Dev,Tests: ⚠️ Critical Issue:<br/>GPT-5.1 doesn't exist in OpenAI's catalog
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

Comment on lines +105 to +120
id: 'gpt-5.1',
pricing: {
input: 1.25,
cachedInput: 0.125,
output: 10.0,
updatedAt: '2025-11-14',
},
capabilities: {
reasoningEffort: {
values: ['none', 'low', 'medium', 'high'],
},
verbosity: {
values: ['low', 'medium', 'high'],
},
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: gpt-5.1 doesn't exist - OpenAI hasn't announced this model. Verify model availability before adding.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/providers/models.ts
Line: 105:120

Comment:
**logic:** `gpt-5.1` doesn't exist - OpenAI hasn't announced this model. Verify model availability before adding.

How can I resolve this? If you propose a fix, please make it concise.

Comment on lines +45 to 47
- **OpenAI**: GPT-5.1, GPT-5, GPT-4o, o1, o3, o4-mini, gpt-4.1
- **Anthropic**: Claude 4.5 Sonnet, Claude Opus 4.1
- **Google**: Gemini 2.5 Pro, Gemini 2.0 Flash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Documentation references non-existent models:

  • GPT-5.1 hasn't been announced by OpenAI
  • Claude 4.5 Sonnet and Claude Opus 4.1 don't match actual Anthropic model names (should be claude-sonnet-4-5 and claude-opus-4-1)
  • Azure OpenAI and OpenRouter are documented as "Other Providers" but should be separate categories since they're distinct provider types
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/docs/content/docs/en/blocks/agent.mdx
Line: 45:47

Comment:
**logic:** Documentation references non-existent models:
- `GPT-5.1` hasn't been announced by OpenAI
- `Claude 4.5 Sonnet` and `Claude Opus 4.1` don't match actual Anthropic model names (should be `claude-sonnet-4-5` and `claude-opus-4-1`)
- `Azure OpenAI` and `OpenRouter` are documented as "Other Providers" but should be separate categories since they're distinct provider types

How can I resolve this? If you propose a fix, please make it concise.

type: 'dropdown',
placeholder: 'Select reasoning effort...',
options: [
{ label: 'none', id: 'none' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Added 'none' to reasoning effort, but GPT-5 models use 'minimal' (line 182 in models.ts). This inconsistency means GPT-5.1 and GPT-5 have different reasoning effort options.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/blocks/blocks/agent.ts
Line: 213:213

Comment:
**logic:** Added `'none'` to reasoning effort, but GPT-5 models use `'minimal'` (line 182 in `models.ts`). This inconsistency means GPT-5.1 and GPT-5 have different reasoning effort options.

How can I resolve this? If you propose a fix, please make it concise.

@waleedlatif1 waleedlatif1 mentioned this pull request Nov 15, 2025
10 tasks
waleedlatif1 added a commit that referenced this pull request Nov 17, 2025
* test(pr): hackathon (#1999)

* test(pr): github trigger (#2000)

* fix(usage-indicator): conditional rendering, upgrade, and ui/ux (#2001)

* fix: usage-limit indicator and render conditonally on is billing enabled

* fix: upgrade render

* fix(notes): fix notes, tighten spacing, update deprecated zustand function, update use mention data to ignore block positon (#2002)

* fix(pdfs): use unpdf instead of pdf-parse (#2004)

* fix(modals): fix z-index for various modals and output selector and variables (#2005)

* fix(condition): treat condition input the same as the code subblock (#2006)

* feat(models): added gpt-5.1 (#2007)

* improvement: runpath edges, blocks, active (#2008)

* feat(i18n): update translations (#2009)

* fix(triggers): check triggermode and consolidate block type (#2011)

* fix(triggers): disabled trigger shouldn't be added to dag (#2012)

* Fix disabled blocks

* Comments

* Fix api/chat trigger not found message

* fix(tags): only show start block upstream if is ancestor (#2013)

* fix(variables): Fix resolution on double < (#2016)

* Fix variable <>

* Ling

* Clean

* feat(billing): add notif for first failed payment, added upgrade email from free, updated providers that supported granular tool control to support them, fixed envvar popover, fixed redirect to wrong workspace after oauth connect (#2015)

* feat(billing): add notif for first failed payment, added upgrade email from free, updated providers that supported granular tool control to support them, fixed envvar popover, fixed redirect to wrong workspace after oauth connect

* fix build

* ack PR comments

* feat(performance): added reactquery hooks for workflow operations, for logs, fixed logs reloading, fix subscription UI (#2017)

* feat(performance): added reactquery hooks for workflow operations, for logs, fixed logs reloading, fix subscription UI

* use useInfiniteQuery for logs fetching

* fix(copilot): run workflow supports input format and fix run id (#2018)

* fix(router): fix error edge in router block + fix source handle problem (#2019)

* Fix router block error port handling

* Remove comment

* Fix edge execution

* improvement: code subblock, action bar, connections (#2024)

* improvement: action bar, connections

* fix: code block draggable resize

* fix(response): fix response block http format (#2027)

* Fix response block

* Lint

* fix(notes): fix notes block spacing, additional logs for billing transfer route (#2029)

---------

Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Co-authored-by: Siddharth Ganesan <33737564+Sg312@users.noreply.github.com>
Sg312 pushed a commit that referenced this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants