fix(router): fix error edge in router block + fix source handle problem

[Sg312]

Summary

Fixes router block edge handling

Type of Change

• Bug fix

Testing

Manual

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 16, 2025 2:29am

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed a bug where router blocks would incorrectly generate router-specific source handles even when explicit handles (like error ports) were already set.

• Added condition to check if handle already exists before generating router handle
• Prevents overriding error ports and other explicit source handles on router blocks
• Maintains backward compatibility for router blocks without explicit handles

Confidence Score: 5/5

• This PR is safe to merge with no risk
• The fix is minimal, targeted, and follows the same pattern used for condition blocks. It prevents a clear bug where router blocks would override explicit source handles. The change is defensive (only acts when handle is undefined) and maintains all existing behavior for normal router edges.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/executor/dag/construction/edges.ts	5/5	Fixed router block edge generation to not override existing source handles like error ports

Sequence Diagram

sequenceDiagram
    participant WF as Workflow
    participant EC as EdgeConstructor
    participant GSH as generateSourceHandle
    participant DAG as DAG

    WF->>EC: wireRegularEdges(connections)
    
    loop For each connection
        EC->>GSH: generateSourceHandle(source, target, connection.sourceHandle)
        
        alt Is Condition Block & no handle
            GSH->>GSH: Generate condition handle
        end
        
        alt Is Router Block & no handle
            Note over GSH: Check if handle exists<br/>(e.g., error port)
            GSH->>GSH: Only generate if !handle
            GSH->>GSH: handle = router-{target}
        end
        
        GSH-->>EC: Return handle
        EC->>DAG: addEdge(source, target, handle)
    end

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}