fix(variables): Fix resolution on double <

[Sg312]

Summary

Fix resolution on double <

Type of Change

• Bug fix

Testing

Manual

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 15, 2025 11:05pm

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed variable reference resolution for double bracket scenarios by centralizing regex patterns and preventing matches across adjacent angle brackets.

• Created apps/sim/executor/utils/reference-validation.ts with centralized pattern functions (createReferencePattern, createEnvVarPattern, createCombinedPattern, replaceValidReferences)
• Changed regex pattern from <([^>]+)> to <([^<>]+)> to prevent greedy matching (e.g., <3 <real.ref> now matches as two separate references instead of one)
• Refactored all UI components and executor modules to use centralized utilities for consistency
• The replaceValidReferences function now validates matches using isLikelyReferenceSegment before replacement, ensuring only valid variable references are processed

Confidence Score: 5/5

• Safe to merge - well-architected refactoring with proper validation logic
• The changes demonstrate excellent software engineering practices: centralizing duplicated regex patterns into a dedicated utility module, fixing a specific edge case bug (double bracket matching), and consistently applying the fix across all affected files. The solution is backed by existing tests in references.test.ts that validate the expected behavior.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/executor/utils/reference-validation.ts	5/5	Added new utility module with reference pattern functions to centralize and standardize regex patterns across the codebase
apps/sim/executor/variables/resolver.ts	5/5	Refactored to use centralized replaceValidReferences utility for consistent reference replacement logic
apps/sim/executor/orchestrators/loop.ts	5/5	Updated loop condition evaluation to use replaceValidReferences for proper handling of double bracket scenarios

Sequence Diagram

sequenceDiagram
    participant User as User Input
    participant UI as UI Components
    participant Util as reference-validation
    participant Resolver as Variable Resolver
    participant LoopOrch as Loop Orchestrator
    
    User->>UI: Enter text with double brackets
    UI->>Util: createReferencePattern()
    Util-->>UI: RegExp pattern
    Note over UI,Util: Pattern changed from [^>]+ to [^<>]+<br/>to prevent matching across brackets
    
    UI->>Util: replaceValidReferences(text, replacer)
    Util->>Util: Apply createReferencePattern()
    Util->>Util: Check isLikelyReferenceSegment()
    alt Valid reference
        Util->>UI: Call replacer callback
    else Invalid reference
        Util-->>UI: Return original
    end
    
    Resolver->>Util: replaceValidReferences(template)
    Util->>Resolver: Process valid references
    Resolver->>Resolver: resolveSingleReference()
    
    LoopOrch->>Util: replaceValidReferences(condition)
    Util->>LoopOrch: Process condition
    LoopOrch->>Resolver: resolveSingleReference()

Loading

[greptile-apps]

_{7 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}