fix(triggers): check triggermode and consolidate block type

[Sg312]

Summary

Fixes incorrect triggers.enabled param to use triggerMode instead. Consolidates block type.

Type of Change

• Bug fix

Testing

Manual

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 15, 2025 7:57pm

[greptile-apps]

Greptile Overview

Greptile Summary

Refactored trigger classification logic to correctly distinguish between static block configuration and instance-level trigger mode. Changed from checking deprecated triggers.enabled property to using triggerMode property on block instances, and consolidated type definitions for better clarity. The fix ensures trigger blocks are properly identified by checking both the block's category (from registry) and its instance-level triggerMode flag.

Confidence Score: 4/5

• This PR is safe to merge with minimal risk
• The changes correctly fix the trigger classification logic by using the proper instance-level triggerMode property instead of the static triggers.enabled config. The refactoring simplifies the code and makes it more maintainable. However, there are no tests to verify the behavior, and the PR description lacks detail about what was fixed and why
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/lib/workflows/triggers.ts	4/5	Refactored classifyStartBlock to check instance-level triggerMode instead of static triggers.enabled config, simplified type definitions, and consolidated block type checking logic

Sequence Diagram

sequenceDiagram
    participant Caller
    participant classifyStartBlock
    participant BlockState
    participant getBlock
    participant BlockRegistry
    participant classifyStartBlockType

    Caller->>classifyStartBlock: call with block
    classifyStartBlock->>BlockState: cast to Partial<BlockState>
    classifyStartBlock->>BlockState: read triggerMode property
    BlockState-->>classifyStartBlock: return triggerMode value
    classifyStartBlock->>getBlock: getBlock(block.type)
    getBlock->>BlockRegistry: lookup block config
    BlockRegistry-->>getBlock: return BlockConfig
    getBlock-->>classifyStartBlock: return blockConfig
    classifyStartBlock->>classifyStartBlock: extract category from blockConfig
    classifyStartBlock->>classifyStartBlockType: call with type, category, triggerModeEnabled
    classifyStartBlockType->>classifyStartBlockType: check type against TRIGGER_TYPES
    alt is known trigger type
        classifyStartBlockType-->>classifyStartBlock: return specific StartBlockPath
    else is unknown type
        classifyStartBlockType->>classifyStartBlockType: check if category='triggers' or triggerModeEnabled=true
        alt matches criteria
            classifyStartBlockType-->>classifyStartBlock: return EXTERNAL_TRIGGER
        else
            classifyStartBlockType-->>classifyStartBlock: return null
        end
    end
    classifyStartBlock-->>Caller: return StartBlockPath or null

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}