Added Support for Dell EMC S5212f in SONiC - #8678
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request introduces 44 alerts when merging 6a6b12c into 7c9be31 - view on LGTM.com new alerts:
|
|
Addressed all LGTM alerts except Wrong name/number of the argument alerts are due to different platform definitions. |
|
This pull request introduces 30 alerts when merging 8fb6471 into f4dea87 - view on LGTM.com new alerts:
|
|
This pull request introduces 14 alerts when merging 93b0fa7 into f4dea87 - view on LGTM.com new alerts:
|
|
This pull request introduces 12 alerts when merging fa790e7 into 63ba489 - view on LGTM.com new alerts:
|
|
@sujinmkang @prgeor - Can you review and approve the changes ? |
prgeor
left a comment
There was a problem hiding this comment.
@thaj-deen can you fix LGTM warnings?
|
@thaj-deen Can you rebase this and please address for the prince's comment? |
|
This pull request introduces 12 alerts when merging a0c79ea953073ce08ac9c4d4e1aa837d37f986f8 into c668f2a - view on LGTM.com new alerts:
|
a0c79ea to
181bc35
Compare
|
Merged and resolved the conflicts @prgeor - Resolved LGTM warning - The wrong name/number of the argument alerts are due to different platform definitions. |
@sujinmkang - Addressed your comment |
|
@sujinmkang @prgeor - close the PR by mistake |
|
This pull request introduces 11 alerts when merging ec79793 into c668f2a - view on LGTM.com new alerts:
|
Why I did it Added Support for Dell EMC S5212f platform How I did it Implemented the support for Dell EMC S5212f platform Platform: x86_64-dellemc_s5212f_c3538-r0 HwSKU: DellEMC-S5212f-P-25G ASIC: broadcom ASIC Count: 1 How to verify it Verified the show command outputs
Why I did it
Added Support for Dell EMC S5212f platform
How I did it
Implemented the support for Dell EMC S5212f platform
Platform: x86_64-dellemc_s5212f_c3538-r0
HwSKU: DellEMC-S5212f-P-25G
ASIC: broadcom
ASIC Count: 1
How to verify it
Verified the show command outputs
Attached the test logs
S5212-COMM-SONIC-Test-Logs.txt
Which release branch to backport (provide reason below if selected)
Description for the changelog
This Pull request contains the Platform and Device dependent files to onboard Dell EMC S5212f
A picture of a cute animal (not mandatory but encouraged)