Skip to content

Conversation

oblm
Copy link
Contributor

@oblm oblm commented Dec 16, 2019

Corresponding GDK pr: spatialos/UnrealGDK#1612

Joe-Improbable and others added 12 commits October 21, 2019 13:40
The CI now uses Setup.bat, due to changes in the Unreal GDK CI pipeline, therefore the additional step (GV-29) is no longer needed.

* Try to adapt to setup-gdk changes

* Switch to project plugin build
* Update buildkite queue

from v3-1569490589-f9345a43b21a6cec-------z to v3-1572523200-2f33678e336fc673-------z

* enable fastbuild on build agent

* revert fastbuild and add debug logging

* explicitly remove fastbuild from path

* improve fastbuild removal

* re-enable fastbuild

* change image to one without FASTbuild

* add comment

* remove unhelpful debugging artifact
* change slack notifications

* fix brace

* always send slack message

* add buildtool logs

* better logging and slack message

* fix slack integration

* fix json message

* test slack message

* fix slack message

* fix array extension

* fix condition

* update slack message

* allow slack notification for non-master branches

* improve message

* improve slack message

* clean up slack message button text

* remove unnecessary check

* remove further unnecessary check

* Update ci/deploy.ps1

Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>

* Update ci/deploy.ps1

Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>

* Update ci/deploy.ps1

Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>

* Update ci/deploy.ps1

Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>

* Update ci/deploy.ps1

Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>

* build slack text in a cleaner way
* fix string truncation

* fix substring

* change to canonical capitalization
Enables multiple engine versions to be tested simultaneously in CI, by reusing the GDK's unreal-engine.version file.
* [UNR-2425][MS] Fixing bug with sim players not moving.

* [UNR-2425][MS] Improvements. The previous version broke the SimPlayers that can be spawned using editor settings.

* [UNR-2425][MS] Wanted to add this to a different PR but this one does rely on it so...
@improbable-prow-robot improbable-prow-robot added the jira/no-ticket Indicates a PR has no corresponding JIRA ticket label Dec 16, 2019
@oblm oblm requested a review from m-samiec December 16, 2019 16:44
@improbable-prow-robot improbable-prow-robot added the size/L Denotes a PR that changes 150-299 lines, ignoring generated files. label Dec 16, 2019
@ernopp ernopp self-requested a review December 17, 2019 14:10
Copy link
Collaborator

@m-samiec m-samiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One query - looks good

@joshuahuburn joshuahuburn merged commit fdbfd33 into preview Dec 17, 2019
@joshuahuburn joshuahuburn deleted the 0.8.0-preview-rc branch December 17, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/L Denotes a PR that changes 150-299 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants