Add bit_reverse for SIMD backend

[andrewmilson]

This change is 

[andrewmilson]

• Add benchmarks for SIMD fft #609
• Add benchmarks for SIMD quotients #608
• Add benchmarks for SIMD eval_at_point #607
• Add benchmarks for SIMD bit_reverse #606
• Implement QuotientOps for SIMD backend #605
• Implement AccumulationOps for SIMD backend #604
• Implement FriOps for SIMD backend #603
• Implement PolyOps for SIMD backend #599
• Modify FFT implementation for SIMD backend #596
• Add FFT implementation for SIMD backend #602
• Modify blake2s implementation for SIMD backend #595
• Add blake2s implementation for SIMD backend #601
• Modify bit_reverse for SIMD backend #594
• Add bit_reverse for SIMD backend #600 👈
• Implement FieldOps for SIMD backend #593
• Add SIMD backend arithmetic #592
• Enable 'rng.gen()'ing field types #591
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andrewmilson and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 98.90110% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.27%. Comparing base (8ed4d95) to head (da34ddc).

Files	Patch %	Lines
crates/prover/src/core/backend/simd/bit_reverse.rs	98.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #600      +/-   ##
==========================================
+ Coverage   91.18%   91.27%   +0.08%     
==========================================
  Files          75       76       +1     
  Lines        9375     9466      +91     
  Branches     9375     9466      +91     
==========================================
+ Hits         8549     8640      +91     
- Misses        756      757       +1     
+ Partials       70       69       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @andrewmilson)

---

crates/prover/src/core/backend/simd/bit_reverse.rs line 1 at r1 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

Tried to make this file as close of a direct copy of backend/avx512/bit_reverse.rs. Most of the changes are just switching types i.e. __m512i replaced with u32x16

Ty, those comments are helpful

---

crates/prover/src/core/backend/simd/bit_reverse.rs line 94 at r2 (raw file):

            0b11100, 0b01101, 0b11101, 0b01110, 0b11110, 0b01111, 0b11111,
        ])
    };

Remove?

Code quote:

    // L is an input to _mm512_permutex2var_epi32, and it is used to
    // interleave the first half of a with the first half of b.
    const _L: u32x16 = unsafe {
        core::mem::transmute([
            0b00000, 0b10000, 0b00001, 0b10001, 0b00010, 0b10010, 0b00011, 0b10011, 0b00100,
            0b10100, 0b00101, 0b10101, 0b00110, 0b10110, 0b00111, 0b10111,
        ])
    };
    // H is an input to _mm512_permutex2var_epi32, and it is used to interleave the second half
    // interleave the second half of a with the second half of b.
    const _H: u32x16 = unsafe {
        core::mem::transmute([
            0b01000, 0b11000, 0b01001, 0b11001, 0b01010, 0b11010, 0b01011, 0b11011, 0b01100,
            0b11100, 0b01101, 0b11101, 0b01110, 0b11110, 0b01111, 0b11111,
        ])
    };

[andrewmilson]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

---

crates/prover/src/core/backend/simd/bit_reverse.rs line 94 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Remove?

They get removed in the next PR https://reviewable.io/reviews/starkware-libs/stwo/594

[shaharsamocha7]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

[shaharsamocha7]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

[spapinistarkware]

Reviewed 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)