Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement QuotientOps for SIMD backend #605

Merged
merged 2 commits into from
May 16, 2024

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented May 2, 2024

This change is Reviewable

@andrewmilson andrewmilson requested a review from alonh5 May 2, 2024 20:35
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from 8ae3239 to ca3f00e Compare May 2, 2024 20:48
@andrewmilson andrewmilson force-pushed the 05-02-Implement_QuotientOps_for_SIMD_backend branch from 00c17e8 to bcd621c Compare May 2, 2024 20:48
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from ca3f00e to 8d2dcfb Compare May 2, 2024 20:57
@andrewmilson andrewmilson force-pushed the 05-02-Implement_QuotientOps_for_SIMD_backend branch from bcd621c to 2d18ccf Compare May 2, 2024 20:57
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (3f1588d) to head (2d18fc3).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #605      +/-   ##
==========================================
+ Coverage   92.90%   93.47%   +0.57%     
==========================================
  Files          83       84       +1     
  Lines       11728    11901     +173     
  Branches    11728    11901     +173     
==========================================
+ Hits        10896    11125     +229     
+ Misses        755      694      -61     
- Partials       77       82       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 05-02-Implement_QuotientOps_for_SIMD_backend branch from b54200f to 1af2f44 Compare May 6, 2024 20:01
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from f287dc2 to 81a10f4 Compare May 7, 2024 00:58
@andrewmilson andrewmilson force-pushed the 05-02-Implement_QuotientOps_for_SIMD_backend branch from 1af2f44 to 8adf68c Compare May 7, 2024 00:58
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from 81a10f4 to d4dcd3a Compare May 7, 2024 18:51
@andrewmilson andrewmilson force-pushed the 05-02-Implement_QuotientOps_for_SIMD_backend branch from 8adf68c to e521e82 Compare May 7, 2024 18:51
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from d4dcd3a to 6497894 Compare May 8, 2024 15:45
@andrewmilson andrewmilson force-pushed the 05-02-Implement_QuotientOps_for_SIMD_backend branch from e521e82 to 319ff78 Compare May 8, 2024 15:45
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @alonh5)

@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from 6497894 to 971f47d Compare May 11, 2024 00:35
@andrewmilson andrewmilson force-pushed the 05-02-Implement_QuotientOps_for_SIMD_backend branch from 319ff78 to b54bba1 Compare May 11, 2024 00:36
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from 971f47d to c7f2f88 Compare May 11, 2024 02:42
@andrewmilson andrewmilson force-pushed the 05-02-Implement_QuotientOps_for_SIMD_backend branch from b54bba1 to 371f407 Compare May 11, 2024 02:42
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from c7f2f88 to fdc404c Compare May 15, 2024 04:34
@andrewmilson andrewmilson force-pushed the 05-02-Implement_QuotientOps_for_SIMD_backend branch from 371f407 to 1701d0e Compare May 15, 2024 04:34
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from fdc404c to 1db70f3 Compare May 15, 2024 19:38
@andrewmilson andrewmilson force-pushed the 05-02-Implement_QuotientOps_for_SIMD_backend branch from 1701d0e to 4d902f6 Compare May 15, 2024 19:38
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from 1db70f3 to bfd5404 Compare May 16, 2024 03:56
@andrewmilson andrewmilson force-pushed the 05-02-Implement_QuotientOps_for_SIMD_backend branch from 4d902f6 to 8284fec Compare May 16, 2024 03:56
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from bfd5404 to c2af92b Compare May 16, 2024 13:57
Base automatically changed from 05-02-Implement_AccumulationOps_for_SIMD_backend to dev May 16, 2024 14:00
@andrewmilson andrewmilson force-pushed the 05-02-Implement_QuotientOps_for_SIMD_backend branch from 8284fec to 2d18fc3 Compare May 16, 2024 14:26
@andrewmilson andrewmilson merged commit c9a33d0 into dev May 16, 2024
21 of 22 checks passed
@andrewmilson andrewmilson deleted the 05-02-Implement_QuotientOps_for_SIMD_backend branch May 16, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants