-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GkrOps for CPU backend #621
Conversation
2a8a41e
to
067098e
Compare
30e285e
to
be651e7
Compare
3c5a3fc
to
a014862
Compare
be651e7
to
e16418e
Compare
66728bd
to
753aad2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
crates/prover/src/core/backend/cpu/lookups/gkr.rs
line 17 at r1 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
I would prefer to allocate this with capacity.
consider implementing this iteratively instead, if it helps.
Done.
8cd2fd4
to
aaad529
Compare
753aad2
to
fbd5d23
Compare
aaad529
to
30790f2
Compare
fbd5d23
to
5705279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @andrewmilson and @spapinistarkware)
crates/prover/src/core/backend/cpu/lookups/gkr.rs
line 3 at r2 (raw file):
use crate::core::backend::CpuBackend; use crate::core::fields::qm31::SecureField; use crate::core::lookups::gkr::GkrOps;
Shouldn't it be gkr_prover? can you rebase?
Code quote:
use crate::core::lookups::gkr::GkrOps;
crates/prover/src/core/backend/cpu/lookups/gkr.rs
line 48 at r2 (raw file):
let y = [7, 3].map(|v| BaseField::from(v).into()); let eq_evals = CpuBackend::gen_eq_evals(&y, one);
Consider to test it with v != one.
Code quote:
let eq_evals = CpuBackend::gen_eq_evals(&y, one);
38cef08
to
778d86c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7 and @spapinistarkware)
crates/prover/src/core/backend/cpu/lookups/gkr.rs
line 3 at r2 (raw file):
Previously, shaharsamocha7 wrote…
Shouldn't it be gkr_prover? can you rebase?
Thanks, updated
30790f2
to
07a2359
Compare
158add9
to
40a1a18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)
40a1a18
to
8a53b70
Compare
…D_backend' into 06-16-add_lookup_final_boundary_constraints * origin/05-24-Implement_LogupOps_for_SIMD_backend: Implement LogupOps for SIMD backend Implement GrandProductOps for SIMD backend Implement GkrOps for SIMD backend Implement MleOps for SIMD backend Add GKR implementation of Logup lookups Add GKR implementation of Grand Product lookups Implement GkrOps for CPU backend (#621) Add batch GKR prover and verifier (#581) add parallelization feature for Merkle tree (#658)
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)