Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for SIMD quotients #608

Merged
merged 1 commit into from
May 16, 2024

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented May 2, 2024

This change is Reviewable

@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from 4d2fca4 to f5c624a Compare May 2, 2024 23:25
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from ae0cc0c to aea0793 Compare May 2, 2024 23:25
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.92%. Comparing base (40adede) to head (3c6716f).

Files Patch % Lines
crates/prover/src/core/poly/circle/evaluation.rs 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                               Coverage Diff                               @@
##           05-02-Add_benchmarks_for_SIMD_eval_at_point     #608      +/-   ##
===============================================================================
- Coverage                                        92.99%   92.92%   -0.07%     
===============================================================================
  Files                                               84       84              
  Lines                                            11505    11513       +8     
  Branches                                         11505    11513       +8     
===============================================================================
  Hits                                             10699    10699              
- Misses                                             725      733       +8     
  Partials                                            81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from f5c624a to 8d3f4bb Compare May 2, 2024 23:30
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from aea0793 to 44bffd2 Compare May 2, 2024 23:30
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from 8d3f4bb to 94901b3 Compare May 3, 2024 00:43
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from 44bffd2 to b0cd631 Compare May 3, 2024 00:43
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from 94901b3 to 75769b2 Compare May 3, 2024 00:51
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from b0cd631 to a263655 Compare May 3, 2024 00:51
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from 75769b2 to aef30f2 Compare May 3, 2024 00:53
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch 2 times, most recently from 3aabf5a to 0501dd5 Compare May 3, 2024 00:56
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from f9aad0b to 922422f Compare May 6, 2024 20:01
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from a783199 to d66361b Compare May 6, 2024 20:01
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from 922422f to cdffe4e Compare May 7, 2024 00:58
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from d66361b to 74ddcc9 Compare May 7, 2024 00:58
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from cdffe4e to aadb4cd Compare May 7, 2024 18:51
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from 74ddcc9 to d86bc45 Compare May 7, 2024 18:51
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from aadb4cd to 7ff76cf Compare May 8, 2024 15:46
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from d86bc45 to eca0fc2 Compare May 8, 2024 15:46
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from 7ff76cf to 9784554 Compare May 11, 2024 00:36
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from eca0fc2 to 4c1bf2f Compare May 11, 2024 00:36
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from 9784554 to 66231a6 Compare May 11, 2024 02:43
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from 4c1bf2f to 701860c Compare May 11, 2024 02:43
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from 66231a6 to ae62ccc Compare May 15, 2024 04:34
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from 701860c to 5da2038 Compare May 15, 2024 04:34
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from ae62ccc to ea4914f Compare May 15, 2024 19:38
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from 5da2038 to 59ba58c Compare May 15, 2024 19:38
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from ea4914f to 40adede Compare May 16, 2024 03:56
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from 59ba58c to 3c6716f Compare May 16, 2024 03:56
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_eval_at_point branch from 40adede to 9dd0967 Compare May 16, 2024 14:49
Base automatically changed from 05-02-Add_benchmarks_for_SIMD_eval_at_point to dev May 16, 2024 14:53
@andrewmilson andrewmilson force-pushed the 05-02-Add_benchmarks_for_SIMD_quotients branch from 3c6716f to 871dfdc Compare May 16, 2024 14:54
@andrewmilson andrewmilson merged commit 3e442a7 into dev May 16, 2024
22 checks passed
@andrewmilson andrewmilson deleted the 05-02-Add_benchmarks_for_SIMD_quotients branch May 16, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants