Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify blake2s implementation for SIMD backend #595

Merged
merged 1 commit into from
May 16, 2024

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented May 1, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 92.98246% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 91.09%. Comparing base (f2c90cd) to head (64fd01c).

Files Patch % Lines
crates/prover/src/core/backend/simd/blake2s.rs 92.98% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #595      +/-   ##
==========================================
+ Coverage   91.02%   91.09%   +0.06%     
==========================================
  Files          77       77              
  Lines        9807     9790      -17     
  Branches     9807     9790      -17     
==========================================
- Hits         8927     8918       -9     
+ Misses        811      803       -8     
  Partials       69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 04-30-Add_bit_reverse_for_SIMD_backend branch from faed46b to d56ea1d Compare May 1, 2024 04:42
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from 89b71dc to 05e275f Compare May 1, 2024 04:42
@andrewmilson andrewmilson force-pushed the 04-30-Add_bit_reverse_for_SIMD_backend branch from d56ea1d to bf357b0 Compare May 1, 2024 15:59
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch 2 times, most recently from a5463cc to 1c2de17 Compare May 1, 2024 16:04
@andrewmilson andrewmilson force-pushed the 04-30-Add_bit_reverse_for_SIMD_backend branch from bf357b0 to ce999c2 Compare May 2, 2024 02:36
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from 1c2de17 to 6ffe5a9 Compare May 2, 2024 04:42
@andrewmilson andrewmilson changed the title Add blake2s implementation for SIMD backend Modify blake2s implementation for SIMD backend May 2, 2024
@andrewmilson andrewmilson force-pushed the 04-30-Add_bit_reverse_for_SIMD_backend branch from ce999c2 to e04a2f6 Compare May 2, 2024 15:53
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from 6ffe5a9 to 948ab4d Compare May 2, 2024 15:53
@andrewmilson andrewmilson changed the base branch from 04-30-Add_bit_reverse_for_SIMD_backend to 05-02-Add_blake2s_implementation_for_SIMD_backend May 2, 2024 16:22
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from 948ab4d to 91c40c5 Compare May 2, 2024 16:22
@andrewmilson andrewmilson force-pushed the 05-02-Add_blake2s_implementation_for_SIMD_backend branch from e84bf9a to 962b3b7 Compare May 2, 2024 16:29
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from 91c40c5 to 705a536 Compare May 2, 2024 16:29
@andrewmilson andrewmilson force-pushed the 05-02-Add_blake2s_implementation_for_SIMD_backend branch from 962b3b7 to 4c6a57e Compare May 2, 2024 16:30
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from 705a536 to 005b77b Compare May 2, 2024 16:30
@andrewmilson andrewmilson force-pushed the 05-02-Add_blake2s_implementation_for_SIMD_backend branch from 4c6a57e to 436d936 Compare May 2, 2024 16:35
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch 2 times, most recently from ea7ab37 to db8061a Compare May 2, 2024 16:43
@andrewmilson andrewmilson force-pushed the 05-02-Add_blake2s_implementation_for_SIMD_backend branch from fa27659 to 254d0eb Compare May 6, 2024 19:16
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from eb5afee to f1829d7 Compare May 6, 2024 19:16
@andrewmilson andrewmilson force-pushed the 05-02-Add_blake2s_implementation_for_SIMD_backend branch from 254d0eb to 9626fbb Compare May 6, 2024 19:28
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from f1829d7 to 0080fce Compare May 6, 2024 19:49
@andrewmilson andrewmilson force-pushed the 05-02-Add_blake2s_implementation_for_SIMD_backend branch from 9626fbb to 4a7ffb2 Compare May 7, 2024 18:50
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from 0080fce to 565c049 Compare May 7, 2024 18:50
@andrewmilson andrewmilson force-pushed the 05-02-Add_blake2s_implementation_for_SIMD_backend branch from 4a7ffb2 to ccb0c2e Compare May 8, 2024 15:45
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from 565c049 to 6cbca64 Compare May 8, 2024 15:45
@andrewmilson andrewmilson force-pushed the 05-02-Add_blake2s_implementation_for_SIMD_backend branch from ccb0c2e to c693113 Compare May 10, 2024 21:11
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from 6cbca64 to f6c5046 Compare May 10, 2024 21:12
@andrewmilson andrewmilson force-pushed the 05-02-Add_blake2s_implementation_for_SIMD_backend branch from c693113 to 120b1c5 Compare May 11, 2024 02:41
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from f6c5046 to 6a263ed Compare May 11, 2024 02:41
@andrewmilson andrewmilson force-pushed the 05-02-Add_blake2s_implementation_for_SIMD_backend branch from 120b1c5 to 6182cfc Compare May 15, 2024 04:34
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from 6a263ed to dc11de3 Compare May 15, 2024 04:34
@andrewmilson andrewmilson force-pushed the 05-02-Add_blake2s_implementation_for_SIMD_backend branch from 6182cfc to 9f342e8 Compare May 15, 2024 15:03
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from dc11de3 to 1b95f6d Compare May 15, 2024 15:08
Base automatically changed from 05-02-Add_blake2s_implementation_for_SIMD_backend to dev May 15, 2024 15:16
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from 1b95f6d to aa6e648 Compare May 15, 2024 19:37
@andrewmilson andrewmilson force-pushed the 04-30-Add_blake2s_implementation_for_SIMD_backend branch from aa6e648 to 64fd01c Compare May 16, 2024 03:56
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

@andrewmilson andrewmilson merged commit 3368cbd into dev May 16, 2024
21 of 22 checks passed
@andrewmilson andrewmilson deleted the 04-30-Add_blake2s_implementation_for_SIMD_backend branch May 16, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants