Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AccumulationOps for SIMD backend #604

Merged
merged 1 commit into from
May 16, 2024

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented May 2, 2024

This change is Reviewable

@andrewmilson andrewmilson force-pushed the 05-02-Implement_FriOps_for_SIMD_backend branch from 8334347 to 81bc768 Compare May 2, 2024 20:34
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from aba6a5a to 8ae3239 Compare May 2, 2024 20:34
@andrewmilson andrewmilson force-pushed the 05-02-Implement_FriOps_for_SIMD_backend branch from 81bc768 to 3680396 Compare May 2, 2024 20:48
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from 8ae3239 to ca3f00e Compare May 2, 2024 20:48
@andrewmilson andrewmilson force-pushed the 05-02-Implement_FriOps_for_SIMD_backend branch from 3680396 to f81b6af Compare May 2, 2024 20:57
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from ca3f00e to 8d2dcfb Compare May 2, 2024 20:57
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 92.41%. Comparing base (82c5535) to head (bfd5404).

Files Patch % Lines
...rates/prover/src/core/backend/simd/accumulation.rs 0.00% 6 Missing ⚠️
crates/prover/src/core/backend/simd/column.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##           05-02-Implement_FriOps_for_SIMD_backend     #604      +/-   ##
===========================================================================
- Coverage                                    92.49%   92.41%   -0.08%     
===========================================================================
  Files                                           82       83       +1     
  Lines                                        11322    11331       +9     
  Branches                                     11322    11331       +9     
===========================================================================
  Hits                                         10472    10472              
- Misses                                         774      783       +9     
  Partials                                        76       76              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from f287dc2 to 81a10f4 Compare May 7, 2024 00:58
@andrewmilson andrewmilson force-pushed the 05-02-Implement_FriOps_for_SIMD_backend branch from 036512e to 0430cf0 Compare May 7, 2024 18:50
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from 81a10f4 to d4dcd3a Compare May 7, 2024 18:51
@andrewmilson andrewmilson force-pushed the 05-02-Implement_FriOps_for_SIMD_backend branch from 0430cf0 to 99e66f2 Compare May 8, 2024 15:45
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from d4dcd3a to 6497894 Compare May 8, 2024 15:45
Copy link
Collaborator

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

@andrewmilson andrewmilson force-pushed the 05-02-Implement_FriOps_for_SIMD_backend branch from 99e66f2 to b7d6d21 Compare May 11, 2024 00:35
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from 6497894 to 971f47d Compare May 11, 2024 00:35
@andrewmilson andrewmilson force-pushed the 05-02-Implement_FriOps_for_SIMD_backend branch from b7d6d21 to 5a7bf34 Compare May 11, 2024 02:42
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from 971f47d to c7f2f88 Compare May 11, 2024 02:42
@andrewmilson andrewmilson force-pushed the 05-02-Implement_FriOps_for_SIMD_backend branch from 5a7bf34 to a40132a Compare May 15, 2024 04:34
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from c7f2f88 to fdc404c Compare May 15, 2024 04:34
@andrewmilson andrewmilson force-pushed the 05-02-Implement_FriOps_for_SIMD_backend branch from a40132a to b3cadb5 Compare May 15, 2024 19:38
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from fdc404c to 1db70f3 Compare May 15, 2024 19:38
@andrewmilson andrewmilson force-pushed the 05-02-Implement_FriOps_for_SIMD_backend branch from b3cadb5 to 82c5535 Compare May 16, 2024 03:56
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from 1db70f3 to bfd5404 Compare May 16, 2024 03:56
@andrewmilson andrewmilson force-pushed the 05-02-Implement_FriOps_for_SIMD_backend branch 4 times, most recently from efb39ee to 09bfbf1 Compare May 16, 2024 13:47
Base automatically changed from 05-02-Implement_FriOps_for_SIMD_backend to dev May 16, 2024 13:56
@andrewmilson andrewmilson force-pushed the 05-02-Implement_AccumulationOps_for_SIMD_backend branch from bfd5404 to c2af92b Compare May 16, 2024 13:57
@andrewmilson andrewmilson merged commit fe29e8b into dev May 16, 2024
12 checks passed
@andrewmilson andrewmilson deleted the 05-02-Implement_AccumulationOps_for_SIMD_backend branch May 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants