-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GKR implementation of Grand Product lookups #620
base: dev
Are you sure you want to change the base?
Add GKR implementation of Grand Product lookups #620
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 05-08-Implement_GkrOps_for_CPU_backend #620 +/- ##
==========================================================================
+ Coverage 89.77% 92.56% +2.78%
==========================================================================
Files 72 72
Lines 9379 9589 +210
Branches 9379 9589 +210
==========================================================================
+ Hits 8420 8876 +456
+ Misses 887 634 -253
- Partials 72 79 +7 ☔ View full report in Codecov by Sentry. |
c359474
to
3c5a3fc
Compare
95cfa41
to
bde8a85
Compare
3c5a3fc
to
a014862
Compare
bde8a85
to
164390d
Compare
a014862
to
66728bd
Compare
164390d
to
79b3a34
Compare
66728bd
to
753aad2
Compare
79b3a34
to
386d3c8
Compare
753aad2
to
fbd5d23
Compare
386d3c8
to
36695ff
Compare
fbd5d23
to
5705279
Compare
36695ff
to
c3b7a95
Compare
5705279
to
38cef08
Compare
c3b7a95
to
162fdcc
Compare
38cef08
to
778d86c
Compare
162fdcc
to
9883b66
Compare
778d86c
to
158add9
Compare
9883b66
to
da2a0e9
Compare
158add9
to
40a1a18
Compare
da2a0e9
to
2a62b8c
Compare
40a1a18
to
8a53b70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 8 files at r1, all commit messages.
Reviewable status: 1 of 11 files reviewed, 4 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)
crates/prover/src/core/backend/cpu/lookups/gkr.rs
line 32 at r3 (raw file):
claim: SecureField, ) -> UnivariatePoly<SecureField> { let k = h.n_variables();
n_variables or n_vars
Suggestion:
n_variables
crates/prover/src/core/backend/cpu/lookups/gkr.rs
line 35 at r3 (raw file):
let n_terms = 1 << (k - 1); let eq_evals = h.eq_evals; let y = eq_evals.y();
What's this? Rename or doc.
crates/prover/src/core/backend/cpu/lookups/gkr.rs
line 51 at r3 (raw file):
let rhs0 = input_layer[(n_terms + i) * 2]; let rhs1 = input_layer[(n_terms + i) * 2 + 1];
Suggestion:
// Input polynomial at points (r,0,bits(i),1), ...
let inp_at_r0i0 = input_layer[i * 2];
let inp_at_r0i1 = input_layer[i * 2 + 1];
let inp_at_r1i0 = input_layer[(n_terms + i) * 2];
let inp_at_r1i1 = input_layer[(n_terms + i) * 2 + 1];
let inp_at_r2i0 = (inp_at_r1i0.double() - inp_at_r0i0);
let inp_at_r2i1 = (inp_at_r0i1.double() - inp_at_r0i1);
crates/prover/src/core/backend/cpu/lookups/gkr.rs
line 54 at r3 (raw file):
let product2 = (rhs0.double() - lhs0) * (rhs1.double() - lhs1); let product0 = lhs0 * lhs1;
Suggestion:
// Product polynomial prod(x) = inp(x,0)*inp(x,1)
// at points (r,0,bits(i)), ...
let prod_at_r0i = inp_at_r0i0 * inp_at_r0i1;
let prod_t_r2i = inp_at_r2i0 * inp_at_r2i1;
2a62b8c
to
b375f43
Compare
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)