Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GkrOps for SIMD backend #630

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented May 16, 2024

This change is Reviewable

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 6 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @andrewmilson)


crates/prover/src/core/backend/simd/lookups/gkr.rs line 21 at r3 (raw file):

        }

        // Start DP with CPU backend to prevent dealing with instances smaller than a SIMD vector.

what's DP?

Code quote:

Start DP with

crates/prover/src/core/backend/simd/lookups/gkr.rs line 22 at r3 (raw file):

        // Start DP with CPU backend to prevent dealing with instances smaller than a SIMD vector.
        let (y_initial, y_rem) = y.split_last_chunk::<{ LOG_N_LANES as usize }>().unwrap();

y_initial is the last 4 elements in the vector, need another name IMO
or maybe comment that we pass on y in reverse order?

Code quote:

let (y_initial, y_rem) = y.split_last_chunk::<{ LOG_N_LANES as usize }>().unwrap();

crates/prover/src/core/backend/simd/lookups/gkr.rs line 70 at r3 (raw file):

    #[test]
    fn gen_eq_evals_matches_cpu() {

Can you also add a test where y.len() < LOG_N_LANES?

Code quote:

fn gen_eq_evals_matches_cpu() {

@andrewmilson andrewmilson force-pushed the 05-15-Implement_MleOps_for_SIMD_backend branch from 5555a3e to 8ceac89 Compare June 25, 2024 02:11
@andrewmilson andrewmilson force-pushed the 05-15-Implement_GkrOps_for_SIMD_backend branch from df87de3 to f19de9e Compare June 25, 2024 02:11
Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 6 files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7 and @spapinistarkware)


crates/prover/src/core/backend/simd/lookups/gkr.rs line 21 at r3 (raw file):

Previously, shaharsamocha7 wrote…

what's DP?

Dynamic Programming


crates/prover/src/core/backend/simd/lookups/gkr.rs line 22 at r3 (raw file):

Previously, shaharsamocha7 wrote…

y_initial is the last 4 elements in the vector, need another name IMO
or maybe comment that we pass on y in reverse order?

Initial in the sense that it's the y values that create the initial values for the algorithm but I see how It's confusing. Changed to y_last_chunk. WDYT?


crates/prover/src/core/backend/simd/lookups/gkr.rs line 70 at r3 (raw file):

Previously, shaharsamocha7 wrote…

Can you also add a test where y.len() < LOG_N_LANES?

Added

@andrewmilson andrewmilson force-pushed the 05-15-Implement_MleOps_for_SIMD_backend branch from 8ceac89 to e175251 Compare June 25, 2024 02:21
@andrewmilson andrewmilson force-pushed the 05-15-Implement_GkrOps_for_SIMD_backend branch from f19de9e to 7188de2 Compare June 25, 2024 02:21
@andrewmilson andrewmilson force-pushed the 05-15-Implement_MleOps_for_SIMD_backend branch from e175251 to c51f096 Compare June 26, 2024 14:33
@andrewmilson andrewmilson force-pushed the 05-15-Implement_GkrOps_for_SIMD_backend branch from 7188de2 to 4968f10 Compare June 26, 2024 14:33
@andrewmilson andrewmilson force-pushed the 05-15-Implement_MleOps_for_SIMD_backend branch from c51f096 to d351947 Compare July 11, 2024 14:05
@andrewmilson andrewmilson force-pushed the 05-15-Implement_GkrOps_for_SIMD_backend branch from 4968f10 to 767cd08 Compare July 11, 2024 14:05
@andrewmilson andrewmilson force-pushed the 05-15-Implement_MleOps_for_SIMD_backend branch from d351947 to ef6c4aa Compare July 11, 2024 14:36
@andrewmilson andrewmilson force-pushed the 05-15-Implement_GkrOps_for_SIMD_backend branch from 767cd08 to 8de5550 Compare July 11, 2024 14:36
@andrewmilson andrewmilson force-pushed the 05-15-Implement_MleOps_for_SIMD_backend branch from ef6c4aa to 89a31c7 Compare July 11, 2024 14:40
@andrewmilson andrewmilson force-pushed the 05-15-Implement_GkrOps_for_SIMD_backend branch from 8de5550 to 51c9107 Compare July 11, 2024 14:40
@andrewmilson andrewmilson force-pushed the 05-15-Implement_MleOps_for_SIMD_backend branch from 89a31c7 to 6b5a7f9 Compare July 15, 2024 13:02
@andrewmilson andrewmilson force-pushed the 05-15-Implement_GkrOps_for_SIMD_backend branch from 51c9107 to 78201c2 Compare July 15, 2024 13:02
@andrewmilson andrewmilson force-pushed the 05-15-Implement_MleOps_for_SIMD_backend branch from 6b5a7f9 to cc39381 Compare July 16, 2024 18:43
@andrewmilson andrewmilson force-pushed the 05-15-Implement_GkrOps_for_SIMD_backend branch 2 times, most recently from 27886bf to 4d47325 Compare July 16, 2024 19:27
Copy link
Collaborator

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r3, 2 of 3 files at r6, all commit messages.
Reviewable status: 5 of 6 files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7)

@andrewmilson andrewmilson force-pushed the 05-15-Implement_MleOps_for_SIMD_backend branch from cc39381 to 967b6f3 Compare July 17, 2024 14:12
@andrewmilson andrewmilson force-pushed the 05-15-Implement_GkrOps_for_SIMD_backend branch from 4d47325 to 6cf72d3 Compare July 17, 2024 14:12
@andrewmilson andrewmilson force-pushed the 05-15-Implement_MleOps_for_SIMD_backend branch from 967b6f3 to 78bd15b Compare July 17, 2024 14:37
@andrewmilson andrewmilson force-pushed the 05-15-Implement_GkrOps_for_SIMD_backend branch from 6cf72d3 to 6f4cd6f Compare July 17, 2024 14:37
Base automatically changed from 05-15-Implement_MleOps_for_SIMD_backend to dev July 17, 2024 14:42
@andrewmilson andrewmilson force-pushed the 05-15-Implement_GkrOps_for_SIMD_backend branch from 6f4cd6f to 5d63696 Compare July 17, 2024 18:09
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

@andrewmilson andrewmilson merged commit 987fd24 into dev Jul 17, 2024
14 checks passed
@andrewmilson andrewmilson deleted the 05-15-Implement_GkrOps_for_SIMD_backend branch July 17, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants