Modifiers convert Values objects to arrays - #5464
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #5436, a Replicator/Bard set or Grid row would now be a Values instance and no longer an array.
We were fine with that being a breaking change, but we can avoid it from breaking too much.
If you were to use certain array modifiers on them, what would previously work will no longer work because they'd have
is_arraychecks in there. e.g.contains,in_array,is_array, etcThis PR will convert
Valuesinstances to their underlying arrays before running each modifier so it behaves exactly like it did before.For cases where a nested item is a
Valuesinstance, we'll still need to manually handle it. See #5462 for an example.