Modifiers convert Values objects to arrays

src/Fields/Values.php

@@ -104,4 +104,9 @@ public function toArray()
     {
         return $this->getProxiedInstance()->toArray();
     }
+
+    public function all()
+    {
+        return $this->getProxiedInstance()->all();
+    }
 }

src/Modifiers/Modify.php

@@ -4,6 +4,7 @@
 
 use ArrayIterator;
 use Exception;
+use Statamic\Fields\Values;
 use Statamic\Support\Arr;
 
 class Modify implements \IteratorAggregate
@@ -189,6 +190,12 @@ protected function runModifier($modifier, $params)
     {
         [$class, $method] = $this->loader->load($modifier);
 
-        return $class->$method($this->value, $params, $this->context);
+        $value = $this->value;
+
+        if ($value instanceof Values) {
+            $value = $value->all();
+        }
+
+        return $class->$method($value, $params, $this->context);
     }
 }

tests/Fields/ValuesTest.php

@@ -56,6 +56,14 @@ public function collection_is_not_converted()
         $this->assertEquals(['foo' => 'bar'], $collection->all());
     }
 
+    /** @test */
+    public function it_can_get_itself_as_an_array()
+    {
+        $values = new Values(collect(['foo' => 'bar']));
+
+        $this->assertEquals(['foo' => 'bar'], $values->all());
+    }
+
     /** @test */
     public function its_arrayable()
     {

tests/Modifiers/FluentModifyTest.php

@@ -2,6 +2,8 @@
 
 namespace Tests\Modifiers;
 
+use Statamic\Fields\Values;
+use Statamic\Modifiers\Modifier;
 use Statamic\Modifiers\Modify;
 use Tests\TestCase;
 
@@ -24,4 +26,32 @@ public function it_can_explicitly_fetch_result()
         $this->assertTrue(is_string($result));
         $this->assertEquals("I LOVE NACHO LIBRE, IT'S THE BESSS!!!", $result);
     }
+
+    /** @test */
+    public function passing_a_values_instance_into_it_will_not_convert_it_to_an_array()
+    {
+        $values = new Values(['foo' => 'bar']);
+
+        $result = Modify::value($values)->fetch();
+
+        $this->assertSame($values, $result);
+    }
+
+    /** @test */
+    public function values_instances_get_converted_to_an_array_when_passing_to_a_modifier()
+    {
+        (new class extends Modifier
+        {
+            public static $handle = 'to_values';
+
+            public function index($value)
+            {
+                return new Values($value);
+            }
+        })::register();
+
+        $result = Modify::value(['foo' => 'bar'])->toValues()->typeOf()->fetch();
+
+        $this->assertEquals('array', $result);
+    }
 }