[6.x] Fix combobox dropdown not showing in modals#12158
Merged
jasonvarga merged 8 commits intomasterfrom Sep 12, 2025
Merged
Conversation
jasonvarga
requested changes
Aug 25, 2025
Member
There was a problem hiding this comment.
Unfortunately this makes it all a bit derpy when tabbing into it.
It happens inside and outside of a modal. Try adding a select field to your publish form and tab into it. Try it on master and this branch and you'll see the difference.
In the modal there's a weird double focus ring now too.
Member
Author
|
@jasonvarga Just pushed up a couple of tweaks. Let me know if it still feels off. CleanShot.2025-08-26.at.15.51.44.mp4 |
This was
linked to
issues
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where it wasn't possible to open the combobox's dropdown inside a modal. According to this comment, you need to wrap
ComboboxViewportinFocusScopefor it to display properly.This PR also makes a slight tweak to the "Create Localization" modal mentioned in the issue, adopting the
<ui-field>component.Fixes #12157.
Fixes #12192.