[6.x] Ensure images are refreshed properly after cropping#14260
Merged
jasonvarga merged 1 commit into6.xfrom Mar 16, 2026
Merged
[6.x] Ensure images are refreshed properly after cropping#14260jasonvarga merged 1 commit into6.xfrom
jasonvarga merged 1 commit into6.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where cropped images weren't updating in the asset editor after replacing the original file.
This was happening because the
bustAndReloadImageCachescallback had two problems:forEachwith anasynccallback doesn't actually await the operations - the callback returns immediately while fetches happen in the backgroundimg.src = urlto the same value doesn't reliably trigger a re-fetch since browsers may optimize this as a no-opThis PR fixes it by:
for...ofloop instead offorEachto properly await each fetch operationremoveAttribute('src')before reassigning the src, which forces the browser to re-fetch from the (now updated) HTTP cacheBefore
CleanShot.2026-03-16.at.11.12.28.mp4
After
CleanShot.2026-03-16.at.11.11.20.mp4
Fixes #14155
Note: I could only reproduce this issue in Safari - Chrome refreshed images as expected.