[6.x] Fix origin() on null when fetching nav tree with origin_id field - #15042
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where fetching a nav tree via the REST API with
?fields=origin_idwould throw aCall to a member function origin() on nullerror when the nav contained an item not linked to an entry (e.g. a custom URL or text label).This was happening because
Pagehas noorigin()method, so the call was forwarded to the page's entry via__call, which isnullfor items without an entry reference.This PR fixes it by giving
Pageanorigin()method that safely returnsnullwhen there's no entry, matching its other entry-delegating methods likeslug()andstatus().Fixes #13315