[6.x] Handle download responses in Inertia requests#15050
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where utilities registered with a custom controller action that returns a download wouldn't work — clicking the utility in the Control Panel did nothing.
This was happening because Control Panel links are Inertia visits, and download responses (
StreamedResponse/BinaryFileResponse) have no content for Inertia to work with, so Inertia's middleware treated them as "empty responses" and redirected back to the previous page.This PR fixes it by overriding
onEmptyResponsein theHandleInertiaRequestsmiddleware, so download responses returnInertia::location()instead. This triggers a full browser visit, allowing the browser to handle the download natively.Fixes #14751