[6.x] Prevent errors when Stache indexes contain keys without files - #15052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queries against the Stache can fail with:
This results in a 500 on both the CP and the frontend.
Since paths and indexes are cached under separate keys and invalidated independently, a query using a
whereororderByresolves its keys from a field index, so the index hands back a key of a file that no longer exists.Filtering out the nulls in
Builder::getItems()resolves the issue. Refreshing the Stache remains the fix for the stale index itself but this stops throwing a 500 error.Thank to Ivan for reporting this through support.