[6.x] Forms 2: Give runtime form blueprints unique cache keys - #15330
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q49Rea3WHrqiVjZ5azU7FG
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q49Rea3WHrqiVjZ5azU7FG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where rendering two forms on the same page — like a guestbook page using the
{{ form:submissions }}tag followed by the{{ form:contact }}tag — would throw aField::setFormField(): null givenerror.This was happening because runtime form blueprints don't have a handle, so every form in the request shared the same
blueprint-contents--Blink cache key and cross-contaminated each other's contents.This PR fixes it by giving the runtime blueprint the form's handle, so each form gets its own cache key. This PR also stops a test from saving the runtime blueprint, since the blueprint having a handle means it would now write an actual blueprint file.